Problem Statement:

This color field has no select input below like other fields (see capture-1.png)

Clicking on it, 2 select inputs show up ... (see capture-2.png)

  • first one list existing colors in the palette
  • second one listing units
CommentFileSizeAuthor
capture-2.png9.25 KBsylvain lavielle
capture-1.png19.86 KBsylvain lavielle

Issue fork artisan-3497974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sylvain lavielle created an issue. See original summary.

simon georges’s picture

simon georges commented
Version: 1.1.1 » 1.x-dev
sylvain lavielle’s picture

sylvain lavielle commented
Issue summary: View changes

sylvain lavielle changed the visibility of the branch 3497974-accent-border-color to hidden.

sylvain lavielle changed the visibility of the branch 3497974-accent-border-color to active.

sylvain lavielle opened merge request !9

simon georges’s picture

simon georges commented
Status: Active » Needs review
crzdev’s picture

crzdev commented

Looks nice, thanks for the effort, reviewing asap!

sylvain lavielle’s picture

sylvain lavielle commented

I noticed a little typo too in code to be fixed up : "numberic" -> "numeric". The typo was there before but I propagated it in the MR code, Sorry. I'll shortly fix this .

crzdev’s picture

crzdev commented

No worries, we are getting main idea of using "extra widget" definition; that is 100% backwards compatible. Also not sure why under forms & components extra widgets are not appearing. It will be in MR soon.

crzdev’s picture

crzdev commented

Iteration ready, same concept as "type", "type_default" & "VALID_TYPES" but with "extra_widget", "extra_widget_default" & "VALID_EXTRA_WIDGETS", also definitions or alterations should be much more flexible & easy to use. Note new method "getDefaultDefinition" to achieve that.

alejandro cabarcos’s picture

alejandro cabarcos commented

Reviewed and tested. Merged on 1.x

alejandro cabarcos’s picture

alejandro cabarcos commented
Status: Needs review » Reviewed & tested by the community
alejandro cabarcos’s picture

alejandro cabarcos commented

Moving to fixed.

Thanks Simon and Sylvain for your efforts!

alejandro cabarcos’s picture

alejandro cabarcos commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.