Drupal 10.5 / 11.2 incompatibility

I am also getting the same issue. Do we have any fix for this issue?

Bumping the codemirror/codemirror package in composer.libraries.json from 5.65.8 to 5.65.19 (latest version on the 5.x branch) seems to resolve this issue.

Tried the MR as well.

I even pulled down https://registry.npmjs.org/codemirror/-/codemirror-5.65.19.tgz
and updated libraries/codemirror, but I still get the error.

update libraries/codemirror/lib/codemirror.js

replace the copyObj function with the following

function copyObj(obj, target, overwrite) {
if (!target) { target = {}; }
for (var prop in obj)
{
if (Object.prototype.hasOwnProperty.call(obj, prop) && (overwrite !== false || !Object.prototype.hasOwnProperty.call(target, prop)))
{
target[prop] = obj[prop];
}
}
return target
}

be sure to clear Drupal caches before testing the change.

It would be helpful for this to be added as a patch that can be applied with Composer.

I'll try and get some more time on this today, I was working on that MR in the context of an existing site, I need to pull it into a clean D11 site.

@liam-morland if you add `.diff` on the end of the MR you get a patch for composer. Just be aware it can change when the MR changes.

https://git.drupalcode.org/project/ckeditor_codemirror/-/merge_requests/...

Issue is upstream: https://github.com/cdubz/ckeditor5-source-editing-codemirror/issues/1

@#11 I was referring to the patch in #8, which is not a patch to this module.

We've resolved this temporarily by building the patched version of the upstream library from the MR, adding a copy of the built js to our site, and then patching this module's ckeditor_codemirror.libraries.yml to load our local version.

Issue has been fixed upstream: https://github.com/cdubz/ckeditor5-source-editing-codemirror/issues/1#is...

Had tried the suggested fix in the docroot/libraries/ckeditor5-source-editing-codemirror/src/sourceeditingcodemirror.js file.

/**
* Initializes all CodeMirror instances when entering source edit mode.
*
* @param {module:core/editor/editor} editor
*/
function enterEditingSourceMode( editor ) {
const sourceEditing = editor.plugins.get( 'SourceEditing' );
const sourceEditingCodeMirror = editor.plugins.get( 'SourceEditingCodeMirror' );

for ( const [ , viewWrapper ] of sourceEditing._replacedRoots ) {
const textarea = viewWrapper.childNodes[ 0 ];
var options = {};
Object.assign(options, editor.config.get( 'sourceEditingCodeMirror.options' ));
const cmEditor = global.window.CodeMirror.fromTextArea( textarea, options );

cmEditor.on( 'change', () => {
textarea.value = cmEditor.getValue();
textarea.dispatchEvent( new global.window.Event( 'input' ) );
} );

sourceEditingCodeMirror._cmEditors.push( cmEditor );
}
}

However, after clearing cache in local ddev (drush cr) and in drupal itself, the editors in "CodeMirror source editing" options still do not work/display (highlighting, closing tags automatically, etc.). Also, the doing a browser inspect (using Chrome), still seeing the same console error; Uncaught CKEditorError: obj.hasOwnProperty is not a function...

This fix does not seem to work, we had recently updated from 10.4.7 to 10.5.1 when the CKeditor 5 source options stopped working.
Thanks.

#8 worked for me, but this is an upstream issue as already stated so I had to hack it in there. Here is what I did to fix the issue temporarily for myself in case it's helpful to others. I patched the file (libraries/codemirror/lib/codemirror.js) as described in #8 — here's a gist in case someone just wants the full file: https://gist.github.com/protitude/9d2992291f86109d5806dbcd1ac5f999

Then I committed that fixed file to my patches directory and updated my composer file to copy the updated file under the scripts section, here's a snippet:

    "scripts": {
        "post-drupal-scaffold-cmd": [
            "rm web/libraries/codemirror/lib/codemirror.js && cp patches/codemirror.js web/libraries/codemirror/lib/codemirror.js"
        ],
    }

Now everything is working happily in my deployment. Hopefully this will help others until we get a proper fix upstream

The fix does work that #8 had presented, but for me only after making the subsequent change that #17 suggested in the libraries/codemirror/lib/codemirror.js file. Thanks.

@reepy, you can download the file to the patches directory and reference the downloaded patch/diff file.

This module is essentially doing nothing when on these versions of Drupal. I don't know how to contribute toward fixing this.

Re #16,

Had tried the suggested fix in the docroot/libraries/ckeditor5-source-editing-codemirror/src/sourceeditingcodemirror.js file.

The library wouldn't use the code in the src folder, it uses the minified code file in the build folder.

Here is how to patch and fix the issue on your site automatically with Composer as a workaround.

Download the patch and add the following to your composer.patches.json file:

  "patches": {
    "codemirror/codemirror": {
      "#3531472: Drupal 10.5 / 11.2 incompatibility": "./patches/ckeditor_codemirror-codemirror-LIBRARY-3531472-copyobj-hasownproperty-fix.diff"
    },

Or use the URL:

  "patches": {
    "codemirror/codemirror": {
      "#3531472: Drupal 10.5 / 11.2 incompatibility": "https://www.drupal.org/files/issues/2025-11-13/ckeditor_codemirror-codemirror-LIBRARY-3531472-copyobj-hasownproperty-fix.diff"
    },

I apologize for the long and bulky file name. I wanted it to be clear that the file is patching the library and not the Drupal module, while still making it clear which module and issue it is for.

Note that the codemirror.js file that is patched does not exist in the GitHub repo. It is probably a build artifact or is specific to an older version. Regardless, I manually created the patch file line by line to apply to the file, and the patch file works.

I verified that the syntax highlighting works after applying the patch with Composer.

Thank you @solideogloria! #24 worked great for me.

Patch in #24 worked for me as well.

Increasing the priority to critical now that Drupal 10.4/11.1 is end-of-life.

Patch in #24 worked for me as well. Thank you so much @solideogloria!

The solution is for this MR upstream to be merged into a new release of the library.

https://github.com/codemirror/codemirror5/pull/7154

Until then, patching the library as described in #3531472-24: Drupal 10.5 / 11.2 incompatibility

Upstream MR needs to be merged.

The upstream pull request was merged. Now we just wait for the next release, and then update this module's dependencies, right?

yes, that's correct, once it's released we run composer up codemirror/codemirror

specifically, we're looking for codemirror 5.65.21

so once it is tagged/released:

composer require codemirror/codemirror:'^5.65.21'

5.65.21 is now out

composer require codemirror/codemirror:'^5.65.21'

Maintainer, please credit everyone!

This isn't fixed, for some reason asset-packagist or packagist.org has the old version of codemirror 5.65.8

registry.npmjs.org/codemirror for somehow isn't getting a composer update or is not in asset-packagist.org .

Root composer.json requires codemirror/codemirror ^5.65.21, found codemirror/codemirror[5.65.8] but it does not match the constraint.

Please reach out to the maintainers and let them know that they need to action this.

Ok, it's passing tests now. Unrelated fix included for sanity sake.

Sent messages to both maintainers of this project.

@wells, please add contribution to us in the contribution record. Currently no one is creditted with fixing this.

Many thanks!

I've upgraded to ckeditor_codemirror 3.1.1 yet for some reason I am having issues updating to codemirror/codemirror 5.65.21 .

Additionally, it looks like the webform module also needs to be updated. Not sure if this is conflicting in my case?
modules/contrib/webform/composer.libraries.json

        "codemirror": {
            "type": "package",
            "package": {
                "name": "codemirror/codemirror",
                "version": "5.65.12",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "codemirror"
                },
                "dist": {
                    "url": "https://github.com/components/codemirror/archive/refs/tags/5.65.12.zip",
                    "type": "zip"
                },
                "license": "MIT"
            }
        },

Same. I opened an issue.

#3572421: Update codemirror/codemirror to 5.65.21

@solideogloria thanks for opening the related webform issue! This should help also!

ok in my case, due to our stack, we had another spot that was pinned on 5.65.8, I figured it out, created a PR for that also.

@wells, reminder, please add contribution to us in the contribution record. Currently no one is creditted with fixing this.

Many thanks!

@joseph.olstad I believe I have done that.

I’m not able to be active in the Drupal community these days, but I did try to follow the prompts for the new credit granting system.

https://new.drupal.org/contribution-record/11414257

Is something wrong there?

ok ya it looks good, I guess I'm used to seeing it as a maintainer since I maintain so many projects. It's greyed out and they're checked, so that's good.

Edit: never mind. I tried again and the dependency updated