Still on Drupal 7? Security support for Drupal 7 ended on 5 January 2025. Please visit our Drupal 7 End of Life resources page to review all of your options.One more wall-o-text to tear down.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | locale-language-config-helptxt3.patch | 6.65 KB | yoroy |
| #5 | locale-language-config-helptxt.patch | 5.23 KB | yoroy |
| #2 | locale-language-conf-helptxt.patch | 5.1 KB | yoroy |
Comments
Comment #1
yoroy CreditAttribution: yoroy commentedBefore:
Comment #2
yoroy CreditAttribution: yoroy commentedAfter:
And moved examples for 'URL' and 'Session' to:
URL before:
URL after:
Session before:
Session after:
Comment #3
yoroy CreditAttribution: yoroy commentedThe URL and Session screens could use some internal cleanups now that the help text is added. Curious to hear from mr. test bot first though.
Comment #4
joachim CreditAttribution: joachim commentedWithout the prior version I would have not a clue what 'top-down logic' means.
Something like: 'Each detection method is used in order until one matches.'
We should bear in mind this is a complicated system and as such a detailed explanation is necessary.
Comment #5
yoroy CreditAttribution: yoroy commentedThanks for reviewing! As complicated as this might be, the goal should always be to provide 'just enough' info to get you going (and not to be 'complete' and try to explain everything). We've seen in usability tests that people who started reading the help texts got confused navigated away from the page, though they were at the right one! Whereas people who skipped the help and started tweaking the settings immediately got done what they wanted to do. A bit of trial and error is no problem as long as people keep a sense of making progress.
Anyway!
### Modified overview page:
- Added the bit about 'must be enabled to apply'
- Made the explanation of how the logic works more explicit.
### URL language provider…
- rephrased the label as a question, which removes the need for a description
- added the word 'prefix' in the example above to make clear which example describes which method.
### Session language provider…
- Less verbose description for the text field.
Comment #6
yoroy CreditAttribution: yoroy commentedAlso, help text that pushes almost everything of the actual form below the fold on a 1024*768 is a UX bug. (a.k.a. must get this in, string freeze or not :-)
Comment #7
joachim CreditAttribution: joachim commentedI still think 'logic' is a needless scary word.
I think we can safely take as read that things that aren't enabled are not enabled.
And I think we could be a bit more explicit about 'first to pass is used' -- seeing as we're already taking about using them as detection -- and that then implies 'lower ones ignored' so we can then drop that bit as it's extra bumph that's I think can be taken as read.
'Drag the detection methods into the order they should test for languages. The first method that detects a language will cause the language to be set.'
I'm not managing to get that second sentence to avoid repeating itself, but then I've not had breakfast yet ;)
And regarding URL negotiation -- I'm pretty sure we don't do labels as questions in Drupal UI, so:
'The part of the URL to consider for language'
Is 'request/session' a technical term? Or do we mean 'request or session'?
Comment #8
joachim CreditAttribution: joachim commented'The first method that obtains a result will set the language for the relevant part of the site.'
Hooray for toast.
Comment #9
dries CreditAttribution: dries commentedLet's get this one in! Reroll, reroll!
Comment #10
joachim CreditAttribution: joachim commented> Is 'request/session' a technical term? Or do we mean 'request or session'?
Not much point rerolling until someone answers that bit.
Comment #11
yoroy CreditAttribution: yoroy commentedWe never did questions because there was always a colon added automatically. I had to squeeze the internets pretty hard to get the colon removed so that we may finally start doing it: #67211: Show colon after form title only when there is no other punctuation, comment 41..
'The part of the URL to consider for language' is basically still a question too, you just didn't add 'is ?'
I think I agree with how you want to make this more clear but in expressing more correctly it also gets very formal. Try to use the simpler word if you have a choice (obtains -> gets)
'The first method that gets a result will set the language for the relevant part of the site.' Will reroll in a couple of hours.
Comment #12
joachim CreditAttribution: joachim commentedQuestions look graceless, IMO. They make the current state of the system harder to take in.
And I'm pretty sure the HIGs for OS UIs advise against them -- skimming through my OS X preferences now I can't see any at all.
Comment #13
yoroy CreditAttribution: yoroy commentedComment #14
yoroy CreditAttribution: yoroy commentedTook out the question and added the suggested changes for how to build the negotiation logic :)
Comment #15
dries CreditAttribution: dries commentedLooks great now. Committed to CVS HEAD. Thanks!