- fix the status report width error under IE8
- fix border bug (IE6~7)

IE6~7 do not support TR border.

CommentFileSizeAuthor
#12 system_report.patch1.53 KBdroplet
#11 system_report.patch1.78 KBdroplet
#11 after_patch_ie8.jpg119.99 KBdroplet
#11 after_patch_firefox.jpg138.1 KBdroplet
#11 IE_no_patch.jpg57.05 KBdroplet
#5 report.png37.51 KBdroplet
#3 report.patch1.26 KBdroplet
report.patch1.04 KBdroplet

Comments

droplet’s picture

droplet commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, report.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review
StatusFileSize
new report.patch1.26 KB
aspilicious’s picture

aspilicious commented

Could you provide before after screenshots?

droplet’s picture

droplet commented
StatusFileSize
new report.png37.51 KB

attached a before screenshot. after is same as what you see in FF

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented

subscribe

droplet’s picture

droplet commented
Issue tags: +IE

lets add IE tag

bfroehle’s picture

bfroehle commented
Title: Fix status report » Status report CSS - IE fixes
Issue tags: +CSS
Jeff Burnz’s picture

Jeff Burnz commented

Please explain what this patch does, why we need it and why we should accept an hack for IE8. Also isnt this just a duplicate of #987982: Remove left and right borders for tr.merge-down td and tr.merge-down th surely efforts can be combined in one?

droplet’s picture

droplet commented

hmm.. hard to explain it... browsers with diff behavior for table without FIXED WIDTH of columns.

as @benjifisher mention in #987982, it's different issues. #987982 more target to Bartik only.

actually, it's patch with a few clean up too.

(it's only fix the bug and doesn't change any designs)

droplet’s picture

droplet commented
Title: Status report CSS - IE fixes » Clean up Status report CSS (and IE fix)
Version: 7.x-dev » 8.x-dev
Component: system.module » CSS
StatusFileSize
new IE_no_patch.jpg57.05 KB
new after_patch_firefox.jpg138.1 KB
new after_patch_ie8.jpg119.99 KB
new system_report.patch1.78 KB

No one interest of IE problem, LOL. But it's more than IE now.

This style make browsers used different way to calc table columns width (fixed the problem under IE, see attached images. And it also better in other browsers,e.g.render performance. no harms)

+table.system-status-report{
+  table-layout: fixed;
+  width: 100%;
+}

against Stark theme, no needs these style

-tr.merge-down,
-tr.merge-down td {
-  border-bottom-width: 0 !important;
-}
-tr.merge-up,
-tr.merge-up td {
-  border-top-width: 0 !important;
-}

Only Seven theme needed.

+table.system-status-report tr.merge-down td {
+  border-bottom-width: 0;
+}
+table.system-status-report tr.merge-up td {
+  border-top-width: 0;
+}

IE < 9 do not supports styles on TR

-table.system-status-report tr {
+table.system-status-report td {
   border-bottom: 1px solid #ccc;
 }

It could safely backport as well :)

droplet’s picture

droplet commented
StatusFileSize
new system_report.patch1.53 KB

It's right one.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work 
+++ b/modules/system/system.admin.css
@@ -118,14 +122,6 @@ table.system-status-report tr.error td.status-icon div {
-tr.merge-down,
-tr.merge-down td {
...
-tr.merge-up,
-tr.merge-up td {

+++ b/themes/seven/style.css
@@ -518,6 +518,12 @@ table.system-status-report tr.error {
+table.system-status-report tr.merge-down td {
...
+table.system-status-report tr.merge-up td {

Contributed modules are using the .merge-down/-up feature, too, so limiting the styles to the status report would be a regression.

droplet’s picture

droplet commented
Assigned: droplet » Unassigned
Issue summary: View changes
Sumit kumar’s picture

Sumit kumar commented
Status: Needs work » Needs review
lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Closed (won't fix)

We no longer support IE 6/7/8 so we don't need to fix this in D8. Feel free to reopen to fix this in D7.

droplet’s picture

droplet commented

This is a clean up, more than IE supports.

However no one really care about it after few years, closing is make sense to me :) ( Feeling sad actually )