I'm profiling a Drupal 7 site where theme registry rebuilds take around 700ms, this makes it a good candidate for locking, in the same way it's being added for variables/menu_rebuild() etc.

Initial untested patch, will be testing shortly.

CommentFileSizeAuthor
#2 theme_registry_lock.patch1.99 KBcatch
theme_registry_lock.patch1.99 KBcatch

Comments

Status: Needs review » Needs work

The last submitted patch, theme_registry_lock.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new theme_registry_lock.patch1.99 KB

Without the syntax error.

Status: Needs review » Needs work

The last submitted patch, theme_registry_lock.patch, failed testing.

pwolanin’s picture

pwolanin commented

should this be combined with #147000: Rewrite module_rebuild_cache() and system_theme_data()?

catch’s picture

catch
he/him
Primary language English
commented

@pwolanin - did you mean that patch? Currently it's posted against D6?

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.