When I first asked you to add the Author Pane integration, I had "Send PM" for the text. You changed it to "Send private message" on the grounds that you don't use "PM" anywhere in the module. I just let it go at the time because I didn't think it was worth arguing over but it's really a pain now that I'm trying to style Author Pane a little nicer. The text is so long that it wraps onto two lines which looks goofy with a faux-button background.

Could it either be changed back to "Send PM" or at least drop the "Send" and just have "Private message"? I know it can be changed with string overrides but I'd like to provide a decent "out of the box" experience and not tell people they have to go get another module to make it not wrap onto two lines.

Thanks,

Michelle

CommentFileSizeAuthor
#4 privatemsg_1003902_ap.patch1.11 KBmichelle
#4 privatemsg_1003902_ap_patch_illustration.png70.95 KBmichelle

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Title: Shorten Author Pane string » Change Author Pane link

I just realized I need to get the span in there, too. Could you please change the whole line from:

$variables['privatemsg'] = l(t('Send private message'), $url, array('attributes' => array('class' => 'author-privatemsg-icon', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));

to:

$variables['privatemsg'] = l('<span>' . t('Private message') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));

I think that should do it. Sorry to be a pain. While AP itself is stable, AF is undergoing massive changes and that's affecting AP to some extent. Hopefully this will be it.

Thanks!

Michelle

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Mh, can you provide a patch?

We have integration with both AP 1.x and 2.x, I am not sure what needs to be updated exactly how :)

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Sure, I'll do that tonight. Thanks. :)

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Needs review
StatusFileSize
new privatemsg_1003902_ap_patch_illustration.png70.95 KB
new privatemsg_1003902_ap.patch1.11 KB

Ok, here's the patch and the screenshot you requested on IRC. The patch is against Privatemsg 1.x but I'm pretty sure the files are the same in both. Nothing needs to be done with the AP 1.x integration section as that's not changing.

Thanks!

Michelle

Status: Needs review » Needs work

The last submitted patch, privatemsg_1003902_ap.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: » 6.x-1.x-dev

There is a difference, changing issue version to 6.x-1.x, will port the patch myself to 6.x-2.x.

Thinking about it, I think I actually like "Send PM" more, even though we don't use it currently. The string is changed anyway, something I try to avoid in stable versions, so it doesn't really matter :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#4: privatemsg_1003902_ap.patch queued for re-testing.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Yeah, I hate changing the string now. I should have been firmer about it when you changed it in my original patch. I was just happy that you were handling the integration and decided not to fight it but, as you can see, the longer string just doesn't fit well. I don't want to make AP wider because some people run in 3 columns and the topics are already pretty squished if they don't use the stacked version.

Thanks!

Michelle

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Ok, commited to all branches.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Awesome, thanks!

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.