If a custom theme is created and features[] are specified in the .info file but 'features[] = logo' and/or 'features[] = favicon' are not included in the .info file the following notices are given when the theme's settings are changed (on /admin/appearance/settings/customtheme).

Notice: Undefined index: logo_path in system_theme_settings_validate() (line 624 of /Library/WebServer/Documents/workspace/drupalcvs/modules/system/system.admin.inc).
Notice: Undefined index: favicon_path in system_theme_settings_validate() (line 630 of /Library/WebServer/Documents/workspace/drupalcvs/modules/system/system.admin.inc).
Notice: Undefined index: logo_upload in system_theme_settings_submit() (line 672 of /Library/WebServer/Documents/workspace/drupalcvs/modules/system/system.admin.inc).
Notice: Undefined index: favicon_upload in system_theme_settings_submit() (line 679 of /Library/WebServer/Documents/workspace/drupalcvs/modules/system/system.admin.inc).

(Note the settings still save correctly.)

Comments

ericras’s picture

Supplied patch checks that the mentioned variables are !empty

ericras’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, theme-settings-undefined-index-1004550-1.patch, failed testing.

ericras’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, theme-settings-undefined-index-1004550-1.patch, failed testing.

MTecknology’s picture

I wish there was a 'subscribe' feature so I didn't have to leave comments about bugs that I want to watch because they affect me too...

wiifm’s picture

subscribe, having this very issue on drupal 7.4

BertienBoon’s picture

subscribe, same in drupal 7.7

devin carlson’s picture

Version: 7.x-dev » 8.x-dev
Priority: Minor » Normal

I just ran into this issue. I'll take a look at the patch and see what modifications it requires to pass.

liam morland’s picture

Status: Needs work » Needs review
StatusFileSize
new1.73 KB

A patch for this.

liam morland’s picture

Status: Needs review » Closed (duplicate)