It's a good habit to initialize such variables that have to be used in db_query directly without using a placeholder. However it does not mean direct security threat (discussed with the Security Team), cause it's hard to even install Drupal with register_globals ON - and that would be needed to exploit this, but still, a fix would be nice.

Comments

Status: Needs review » Needs work

The last submitted patch, nodequeue_uninitialized_in_db_query.patch, failed testing.

ezra-g’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Needs work » Patch (to be ported)
amateescu’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

Thanks to DBTNG, this patch doesn't need a port to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.