comment.module uses "E-mail" as label for the e-mail address field. In includes/install.core.inc, modules/user/user.module and modules/system/system.admin.inc the label is "E-mail address".
This patch updates comment.module to follow the convention used in the three other files.
This change does not require any changes to the translations, because both strings are used both before and after the change.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | before-patch.jpg | 34.89 KB | rschwab |
| #5 | after-patch.jpg | 32.12 KB | rschwab |
| #2 | comment-email-2.patch | 2.98 KB | c960657 |
| comment-email-1.patch | 1.23 KB | c960657 |
Comments
Comment #2
c960657 commentedComment #3
droplet commentedPatch is okay. but this is more like by design than mistake.
Comment #4
c960657 commentedWhat is the design rationale behind using two different words for the same thing?
Comment #5
rschwab commentedAttaching images to compare the difference, and tagging for a usability review. Personally I think "E-mail" is equally descriptive with half the word count, so I vote for works as designed.
Comment #6
c960657 commentedIn that case we should change all occurrences of "E-mail address" to "E-mail".
Comment #7
montesq commentedLooks good.
For me E-mail = E-mail address but as c960657 noticed, E-mail address is used everywhere in drupal (site configuration, my account...)
Comment #8
webchickWe can't break strings anymore now that 7.0 shipped, but looks like a good patch for 8.x.
Comment #9
webchickComment #10
dries commentedVisually, the proposed patch looks like a regression on the comment form. It feels more cluttered and more cramped. Aesthetics is sometimes more important than consistency.