The patch more or less speaks for itself.
Not sure what versions should get fixed, but the typo dates back to 5.x at least.

Comments

Status: Needs review » Needs work

The last submitted patch, drupal_comment_comment_typo.patch, failed testing.

zoo33’s picture

Status: Needs work » Needs review
StatusFileSize
new710 bytes

OK, so I'm a git rookie. Trying --no-prefix.

Status: Needs review » Needs work

The last submitted patch, drupal_comment_comment_typo-2.patch, failed testing.

zoo33’s picture

Status: Needs work » Needs review

#2: drupal_comment_comment_typo-2.patch queued for re-testing.

jody lynn’s picture

Status: Needs review » Closed (works as designed)

I don't think it's a typo. An anonymous user can only delete his or her own comment and therefore wants to see that his or her comment has been deleted. The point of it is to satisfy an individual person.

zoo33’s picture

Status: Closed (works as designed) » Needs review

I disagree, although this IS minor, and I could have more elaborate.

The comment stems from the comment_confirm_delete form which is used by any user who deletes a comment – regardless of user role (and gender). When a comment is deleted, it's important to clear the page cache so that it won't get shown to non logged-in, anonymous users. If the user who deletes the comment is in fact anonymous, the current comment would kind of make sense, but it's probably very rare that anonymous users have this permission.

jody lynn’s picture

Category: bug » task
Status: Needs review » Needs work

If that's what you think, then you need to change 'an anonymous user sees' to 'anonymous users see' as well.

But it was not a typo or a bug. It's normal to alternate between 'his' and 'her' when referring to an unknown individual.

zoo33’s picture

Title: Typo in code comment: 'his' -> 'this' » Change comment to better describe why cache is cleared
StatusFileSize
new706 bytes

Fair enough. Attaching a new patch and changing the title.

Just to be clear, the main reason I think this was a typo in the first place is that the 'anonymous user' would rarely be the one deleting the comment.

zoo33’s picture

Status: Needs work » Needs review
lokapujya’s picture

Assigned: Unassigned » lokapujya
Issue summary: View changes
lokapujya’s picture

Assigned: lokapujya » Unassigned
Status: Needs review » Closed (won't fix)