We're so old-skool, man...

CommentFileSizeAuthor
#2 drupal.filter-url-twitter.2.patch2.73 KBsun
drupal.filter-url-twitter.0.patch1.9 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, drupal.filter-url-twitter.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.filter-url-twitter.2.patch2.73 KB

Showcase demonstration for test driven development. This patch should/will pass.

chx’s picture

chx commented
Title: URL filter fails on Twitter URLs » URL filter fails on Google - recognizable AJAX URLs
Status: Needs review » Reviewed & tested by the community

Note that this is NOT twitter specific http://googlewebmastercentral.blogspot.com/2009/10/proposal-for-making-a...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#2: drupal.filter-url-twitter.2.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to HEAD. Thanks!

Does this also need to be back-ported to D6?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-dev » 7.x-dev
Status: Patch (to be ported) » Fixed

While technically possible, URL filter changed too much for D7, and D6 has no tests for it at all, so there's a big risk of breaking it.

Also, I don't think this is too important.

Thus, reverting to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.