Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
image system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jan 2011 at 00:36 UTC
Updated:
27 Jan 2011 at 01:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
redndahead commentedComment #2
bfroehle commentedA quick grep of the code shows that the getsize option isn't getting used anywhere in core. The patch in #1 takes care of two of these mentions, but it should be more thoroughly cleaned up.
Comment #3
redndahead commentedThese parts removed.
Comment #4
bfroehle commentedMany thanks, I'll mark it RTBC after the bot responds. (No rush, since it's likely too late for 7.0).
Comment #5
redndahead commentedready for rtbc
Comment #6
bfroehle commentedAs mentioned by redndahead, #908282: Remove unnecessary I/O from theme_image() removed the 'getsize' functionality and most 'getsize' mentions in the code. This patch removes 'getsize' documentation that was missed in that issue, as well as some stray 'getsize' references. Since that original issue is being used for another purpose at the moment, I'm marking this issue as RTBC. I've left a note in the other issue so they are aware of this change.
Comment #7
dries commentedCommitted to CVS HEAD. If we decide to rollback #908282: Remove unnecessary I/O from theme_image() we can roll back it in one go. I'm not sure a rollback is the right approach so ...