I saw an error using file fields to hidding all my "attachements" itens at one page.

We've 2 files attached using file_field, a normal function for a drupal 7.
If we need to display these 2 itens, we just need to check the "Display" checkbox for each item. Supose we need hide these 2 itens, we just need to UNcheck these 2 checkboxes, but the second item wasn´t hiden.

Follow the patch file to correct this bug and the screenshot of my page.

CommentFileSizeAuthor
#6 file.field_.inc_.patch542 bytesantoanne
#4 file.field.inc.patch550 bytesantoanne
#2 file.field_.inc_.patch455 bytesantoanne
#1 file_field.patch542 bytesdroplet
file_field_bug.jpg101.28 KBantoanne
file.field_.inc_.patch414 bytesantoanne

Comments

droplet’s picture

droplet commented
Status: Active » Needs review
StatusFileSize
new file_field.patch542 bytes

I guess your patch won't pass testbot, reroll patch for bots only.

antoanne’s picture

antoanne commented
StatusFileSize
new file.field_.inc_.patch455 bytes

Follow new patch file. Now using the drupal creating patch tutorial.

Status: Needs review » Needs work

The last submitted patch, file.field_.inc_.patch, failed testing.

antoanne’s picture

antoanne commented
StatusFileSize
new file.field.inc.patch550 bytes

Follow new patch file again. Now using git diff.

droplet’s picture

droplet commented
Status: Needs work » Reviewed & tested by the community

@antoanne,

you need to add no-prefix
actually the patch at #1 is working and webchick will count it as your work :)

because same patch, so RTBC

antoanne’s picture

antoanne commented
StatusFileSize
new file.field_.inc_.patch542 bytes

Let's see if is correct now! ;)

Josh The Geek’s picture

Josh The Geek commented
Version: 7.0 » 7.x-dev

Drupal tests bugs against dev releases.

bfroehle’s picture

bfroehle commented

I'll confirm the issue and have manually tested the patch. +1 RTBC.

montesq’s picture

montesq commented

The patch works well here too...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Marked #1041508: Problem with file_field_prepare_view as a duplicate of this issue. Confirming this is RTBC.

damjan.cvetan’s picture

damjan.cvetan commented

The patch works well. :) I didn't see it before, so the patch is the same as mine.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Better patch with a test in #932426: 2ND file uploaded is displayed when display option is unchecked, so marking this issue as a duplicate.