%element-title in form_error is empty if form element has no title [#1020032]

In GA I'm using fields inside a table and they do not have a #title element. Therefor the form_error ends with The is using the following invalid tokens: [roles-invalid].. You can see the title is missing here. Otherwise I'm not able to set a title for this element or it would get shown in the table listing.

    $form['googleanalytics_custom_var']['slots'][$i]['value'] = array(
      '#default_value' => !empty($googleanalytics_custom_vars['slots'][$i]['value']) ? $googleanalytics_custom_vars['slots'][$i]['value'] : '',
      '#description' => ($token_enabled ? t('The custom variable value. You may use tokens in this field.') : t('The custom variable value.')),
      '#type' => 'textfield',
      '#element_validate' => array('token_element_validate'),
      '#token_types' => array('all'),
    );

How can we solve this and make the form error helpful?

Comment	File	Size	Author
#11	token_elements.patch	706 bytes	hass
#6	token_d6_add_title_invisible.patch	1000 bytes	hass

Comments

Comment #1

hass commented 9 January 2011 at 00:59

Title:

%element-title in form_error is empty if form element have no title

» %element-title in form_error is empty if form element has no title

Comment #2

dave reid

he/him

English

Nebraska USA

commented 9 January 2011 at 01:23

In reality you shouldn't have form elements without a title as it provides no context to users that have to use screen readers, etc. You should be using:

$form['myitem'] = array(
  '#title' => 'Helpful title',
  '#title_display' => 'invisible',
  ...
);

Core itself seems to assume that #title is present, although not always. _form_validate() when checking the #required property of a field does the following:

form_error($elements, $t('!name cannot be longer than %max characters but is currently %length characters long.', array('!name' => empty($elements['#title']) ? $elements['#parents'][0] : $elements['#title'], '%max' => $elements['#maxlength'], '%length' => drupal_strlen($elements['#value']))));

But other element validation functions assume $element['#title'] exists:
http://api.drupal.org/api/drupal/modules--field--field.module/function/_...
http://api.drupal.org/api/drupal/modules--field--field.module/function/_...
http://api.drupal.org/api/drupal/modules--field--field.module/function/_...

Comment #3

dave reid

he/him

English

Nebraska USA

commented 9 January 2011 at 01:24

The D6 version of _form_validate also assumes $element['#title'] always exists.

Comment #4

hass commented 9 January 2011 at 01:31

I was not aware of #title_display... I go with this in D7, but we cannot for D6.

I found more strange issue in token code... 'token_element_validate_token_context' is deprecated in D6, but in token D7 it is the only available validation function. Can you take a look to this, please? May need a new case...