Use theme function for #markup

Ahhhh... the more you know :) Thanks Mile23

Let's give this a shot....

I've been playing around with this tonight, I haven't taken much time to play around with the Render API up until now, so I'm running into a few things that confuse me.

When you say to use a 'render element' type theme function, do you mean having the theme function declared like the following?

    case 'field_example_simple_text':
      $element['#theme'] = 'field_example_simple_text';
      break;

Because when I do that, theme_field is no longer used at all, so the label logic in theme_field would need to be duplicated.

Is there another way to declare the render element type theme function?

I've just been reading through Field Attach API source code and I think you are right about using prefix/suffix as opposed to a theme function, Mile23. I think that using #prefix and #suffix is good to show because it demonstrates how developers can give themers the ability to change out the elements that are used around the content itself.

In the drupal_add_css docs, it says that using the 'file' type is better practice because then the styles are aggregated and cached. I think it is also a better practice because it allows for just that file to be removed or replaced before rendering if need be.

Meant to change to needs work.

Actually, I think I may have figured this out.

I think that this should be a render element of type html_tag kind of like the following

  $elements['system_meta_content_type'] = array(
    '#type' => 'html_tag',
    '#tag' => 'meta',
    '#attributes' => array(
      'http-equiv' => 'Content-Type',
      'content' => 'text/html; charset=utf-8',
    ),
    // Security: This always has to be output first.
    '#weight' => -1000,
  );

sweeeet! I'll take a look at the field_color_background later today

I didn't look at the tests, but I think this may have failed because it used to be a <p> tag.

I changed the first example back to a p, made the comment a little shorter, and created the render array for the background example. It turns out that you can use #attached with inline css.