Hi, i suggest a little code modification of this module to add a new link checker mode option.
The module, at this moment, allow two features : check external link and internal/external link (a checkbox in admin panel).
I add a new one : internal check only.
The code modification take care about the old settings, so configuration's change isn't required after the patch if you don't wan't to change the option from your previous configuration.
Patch will follow.

CommentFileSizeAuthor
#2 linkchecker-1021384.patch3.21 KBZarakay

Comments

Zarakay’s picture

Version: 6.x-2.4 » 6.x-2.x-dev
Zarakay’s picture

StatusFileSize
new3.21 KB
Zarakay’s picture

Assigned: Zarakay » Unassigned
hass’s picture

Status: Active » Needs review
yukare’s picture

This patch is now on last patch in Drupal 7 version.

hass’s picture

Don't mix up patches, please!

pol’s picture

We are using this patch for Drupal 6 and it works successfully !

hass’s picture

Status: Needs review » Needs work

I believe we should change the name of linkchecker_fqdn_only variable to something more logic. This requires an update hook and uninstall update, too. Let's change the name to linkchecker_linkcheck_mode.

Additionally the code style need to be revisited. Here are a few examples.

+++ linkchecker.module	10 Jan 2011 13:45:13 -0000
@@ -999,20 +999,20 @@ function _linkchecker_extract_links($tex
+	$mode = variable_get('linkchecker_fqdn_only', 1);
...
+   	// Skip mailto:, javascript:, etc.

Tab? Always use 2 spaces.

+++ linkchecker.module	10 Jan 2011 13:45:13 -0000
@@ -1048,9 +1048,8 @@ function _linkchecker_extract_links($tex
+	}

Code style

+++ includes/linkchecker.admin.inc	10 Jan 2011 13:45:13 -0000
@@ -39,10 +39,15 @@ function linkchecker_admin_settings_form
+    '#type' => 'select',
+    '#title' => t('Internal and/or external linkcheck mode'),
+    '#description' => t('Choose your linkcheck mode : Internal (/node/123) only, external (full qualified URLs) (http://example.com/foo/bar) only and both (internal and external).'),

Remove space before ":".

Powered by Dreditor.

hass’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev

Moving D7, no back porting planed because of complex update hook logic.

hass’s picture

Status: Needs work » Fixed

Thanks for patch. Committed a re-factored patch to D7: http://drupalcode.org/project/linkchecker.git/commit/072887f

hass’s picture

Decided to backport the feature to D6 without changing the variable name. Variable will be renamed in D7.

http://drupalcode.org/project/linkchecker.git/commit/ba57c85

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.