Global and specific commit logs should show username

Started a fix for this in the views_handler, sadly this approach is kinda doomed until we get a way to join both author_uid and committer_uid to the users table.

Here's an approach that fixes this issue temporarily, albeit only by running another query in render :(

Ugh. ;)

A) I don't really understand why we need the multiple JOINs. I'll ask for clarification on that in IRC.

B) If we have to do a separate query, it's *WAY* better to do a single query for all the users we might need in pre_render(). Search for "pre_render" in project/release/views/handlers/* and you'll see lots of examples.

Committing what we've got here to avoid additional bug reports.

The ugly code path here will probably be uncommon on drupal.org, at least for the initial launch.

Leaving at needs work so we don't forget to circle back.

I think this patch do the work cleanly.

It:

• Revert the last patch committed
• Adds one person_username alias for getting the username, and handle it in a special way(set it) for attribution handler.

I have used dww B) idea (thanks for pointing there!).

BTW not sure why this was opened as bug.

I tried this patch and it's not working after applying this patch. The usernames are not used, and the link to the username fails as well.

This line looks wrong to me, it's setting an alias to the actual of a username (such as 'mikey_p') when used in $values->{$this->aliases['person_username']} it is always empty:

$this->aliases['person_username'] = $this->usernames[$author_uid];

@mikey_p: thanks for noticing it!

Peer review FTW ;-)

Attached the fixed version.

Sorry, wrong patch, ignore "0001-task-994870-follow-up-Missing-controller.patch"

Testing this, and it looks good. RTBC

Committed.

sdboyer added a fix, but it do not handle no users associated, so re-rolling this to actually fix that and commited it.

This was discovered in the middle of re-rolling #1030266: Single commit view should use revision in the title.

Another follow-up after sdboyer suggestion committed.