please provide source files for all .swf files in tarballs

Comments

rsevero’s picture

rsevero commented
Assigned: Unassigned » rsevero

Thanks for the warning. I will look for them and include ASAP.

btbroot’s picture

btbroot commented
Priority: Normal » Critical

Any news on this?

charts_graphs/apis/charts_graphs_bluff/bluff/*.js:
Compressed javascript files are missing source.
charts_graphs/apis/charts_graphs_open_flash/open-flash-chart.swf:
Missing source. LGPL according to README.txt.

rsevero’s picture

rsevero commented
Status: Active » Fixed

Fixed with http://drupalcode.org/project/charts_graphs.git/commit/c4533cb , http://drupalcode.org/project/charts_graphs.git/commit/afcfdad and http://drupalcode.org/project/charts_graphs.git/commit/03234d9

rsevero’s picture

rsevero commented

The actual removal of open-flash-chart.swf only happened at http://drupalcode.org/project/charts_graphs.git/commit/9a6eb71

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

btbroot’s picture

btbroot commented
Version: 6.x-2.6 » 6.x-2.7
Status: Closed (fixed) » Active

I'm afraid it still not fixed. Let me make it clear:

./apis/charts_graphs_bluff/bluff-src.js is ok now: it's dual-licensed and used under GPLv2.

./apis/charts_graphs_bluff/bluff/bluff-min.js is obviousely deriver from the prevous one, but you didn't present the way of creating it (yes, i know, it's pretty straightforward, but technically you have to show it to satisfy GPL). In fact, i personally think it would be better to exclute these optimized JS files from the tarball: it must be responsibility of Drupal optimization feature to compress JS on fly.

./apis/charts_graphs_bluff/bluff/js-class.js still hasn't source.

btbroot’s picture

btbroot commented

ping