Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jan 2011 at 20:53 UTC
Updated:
3 Jan 2014 at 02:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonThanks for reporting! Good project for a novice doc contributor to clean up this doc.
Comment #2
avpadernoComment #3
avpadernoI fixed a typo, and made the title more explicit.
Comment #4
amateescu commentedPatch :)
Comment #5
amateescu commentedComment #6
avpadernoThe test bot is happy and so am I.
Comment #7
jhodgdonThose EM tags were put in for the purpose of highlighting/setting off those words. Perhaps they should be replaced by quotes? I think that would be a good idea.
Comment #8
montesq commentedHere is the patch with double quotes instead of
<em>. Moreover, I think the tag<outline>should not be removed as it's not an html tag but it explains how is formed the opml file.Comment #9
avpadernoshould not be removed as it's not an html tag but it explains how is formed the opml file.
That is what I think too; it is the reason the title makes reference to HTML tags.
Comment #10
jhodgdonWhen text is removed from the last paragraph, the paragraph needs to be rewrapped:
A few words should be moved up to the previous line. Otherwise, I think this patch is fine.
Comment #11
montesq commentedHope this one is the finale one.
Thx for your remarks
Comment #12
avpadernoDo we put an empty line between the last @param and @return?
Comment #13
jhodgdonYes, the empty line between the last @param and the @return is correct in this patch.
This new patch has some spaces at the ends of the lines in the last paragraph. Those need to go...
Comment #14
montesq commentedComment #15
jhodgdonThe first changed line still ends in a space, I think?
You can configure most code-oriented text editors to show whitespace at ends of lines. That will help. In my Emacs, for instance, it is bright red and hard to miss! :)
Comment #16
montesq commentedOh, I'm sorry...
I also use emacs but I didn't notice that. I need to check if this kind of configuration is in place on my personnal compture...
Moreover you talk about the last paragraph, so I didn't look at the beginning of the patch ^^
Comment #17
montesq commentedComment #18
jhodgdonThanks! Now it looks good.
Emacs: put this in your emacs config file (.emacs etc. depending on platform):
'(show-trailing-whitespace t)
Comment #19
montesq commented@jhodgdon
nice tip! Many Thanks
Comment #20
webchickCommitted to HEAD. Thanks!