Login form being colored when the name is missing

Thats not critical...
Or does it prevend anything to happen?

Just a major UX problem...

Reproduced here.
Username & name fields have the same ID, it may be the cause of failure?
However, when I fill in required field of the contact form, the functionality seems OK
-> change the priority to normal according to http://drupal.org/node/45111

Find as attached a patch to fix this.
I've changed the technical name of the field "Your name" to 'visitor-name' (instead of 'name' because this is also the technical name for the username field of the login form).
I don't know if this label is the right one and we could probably improve it. Otherwise, we could rename the field of the login form 'username' (instead of 'name').

To Test:
- Active contact module
- Active contact link in the navigation menu
- Add the permission for anonymous user to access contact form
- log out and go to http://localhost/?q=contact
- submit an empty form
-> expected result: only required fields from the contact form must be in error (=red border)

Ok

Test driven development means you need to alter the tests to ;)

--recall from #4--
Find as attached a patch to fix this.
I've changed the technical name of the field "Your name" to 'visitor-name' (instead of 'name' because this is also the technical name for the username field of the login form).
I don't know if this label is the right one and we could probably improve it. Otherwise, we could rename the field of the login form 'username' (instead of 'name').

To Test:
- Active contact module
- Active contact link in the navigation menu
- Add the permission for anonymous user to access contact form
- log out and go to http://localhost/?q=contact
- submit an empty form
-> expected result: only required fields from the contact form must be in error (=red border)

This is a duplicate of #799356: _form_set_class() is too aggressive in assigning the 'error' class and ultimately #766146: Support multiple forms with same $form_id on the same page