Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Jan 2011 at 09:53 UTC
Updated:
3 Jan 2014 at 02:41 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
yoroy commentedSubscribe :)
For comment 1:
- I would suggest renaming from 'Label' to 'Name' or 'Rule name', because that's what it is. Will make it even easier to drop the description, which is unneccessary indeed.
- Machine name works as intended in my installation
For comment 2:
The description for the active checkbox explains what 'active' or 'enabled' means. Not needed.
For comment 3:
Very cryptic indeed. Main problem seems to be that you can't see the other rules that react on the same event. So you don't know what any other weights are, which means you ask people to remember that info between screens. Humans are quite bad at that. Better would be a drag-n-drop interface to order all rules on the same event.
Comment #2
yoroy commentedAnd
1. I only reworded the string 'Label' to 'Rule name', it's still called a label in the code. I will break things trying to change that :-)
2. Removed the description from 'Active' checkbox
3. Tried to rephrase the rules ordering with fewer and simpler words. Doesn't fix the actual problem though.
Comment #3
yoroy commentedstatus
Comment #4
fagoad 1.
I don't feel good with having a "rule name" that is $rule->label and having a "rule machine name" that is $rule->name. Having Label <-> name is much more clear imho.
Also please make sure to use the latest dev version, I've done machine name fixes recently.
ad 2.
Makes sense.
ad 3.
While the new wording is simpler, I fear its less descriptive. This feature is more an advanced thing you usually won't need, so I don't think we need a drag&drop UI or such for it. Maybe we should just add that usually the default is fine?
Comment #5
fagoThanks, I've tried to improve the description for 3), completed the "name" label renaming and committed it.
Attached patch is what I've committed. Please just re-open if you can think of a better wording.