1. Use D7's class registry and put your base class in a services.test file rather than using requires everywhere
2. Use proper and re-usable setUp() function.
3. Remove references two inputstream and services_sessauth to help more tests pass.

CommentFileSizeAuthor
#8 1030220.patch31.72 KBgdd
#2 1030220-services-tests.patch27.6 KBdave reid
#1 1030220-services-tests.patch32.08 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1030220-services-tests.patch32.08 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1030220-services-tests.patch27.6 KB

Grr, removed hunks from #1029438: services_list_endpoint() does not need to call drupal_render().

kylebrowning’s picture

kylebrowning commented

Hey Dave, we have an ongoing list of changes to the services tests #944340: Functional Endpoint Tests and Unit Tests for services.module, can you re-roll your patch to take into account the changes there. I still need to port those to 7.x and then I would need to merge your changes in. Soo, I guess, Ill add these in once I get those patches rolled into 7.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'd rather not actually. It's much easier to re-adjust the patch in 944340 for the changes accounted for in this patch, which I'd be happy to help do, just not the other way around.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Postponed

ok, ive commited #944340: Functional Endpoint Tests and Unit Tests for services.module but its all 6.x at this, point. Is your patch 7.x specific or should it be applied to 6.x as well? If so, lets wait till that issue is closed and then make these changes against that.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

I have removed and committed the removal of inputstream and sessauth just so current tests arent failing all over the palce. So no matter what happens a slight reroll will be needed.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

Actually I've decided I want to get these mods in sooner rather than later, so I'm going to try and reroll this myself.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Postponed » Needs review
StatusFileSize
new 1030220.patch31.72 KB

Here is a reroll that takes into account various changes since the original was rolled. All tests pass!

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

Works for meh!
Patch applies and tests pass!

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed! Thanks