$subject in privatemsg_get_link() should be url encoded

I haz test 4 u!

And they revealed that it's not that simple to encode a / properly.

The problem is that when clean_url's are enabled, mod_rewrite already decodes the /. This means we need to explicitly encode it twice and decode it again inside privatemsg_new().

And now without debug code and code style fixed.

Thank you testbot! ;)

Testbot doesn't use clean url's, If I only encode / conditially, then I need to do the same for decoding.

Fun stuff.

This patch passes for me both with and without clean_url's. Needs a separate approach. When clean url's are enabled, everything is encoded 2-3 times (because url() is encoding the path again) so that it survives through mod_rewrite and the menu system and everything is passed as a single string as subject.

Wondering about a completely different approach for this, especially since people are asking to control the body field in a similar way. I have no idea how, though.

Needs to be re-rolled.

#8: multiple_encoding_fun.patch queued for re-testing.

Re-rolled the patch.

Commited.

It looks like the special case isn't necessary anymore in D7, the non-clean_url's solution worked too for me when using clean_url's. Let's see what the test bot has to say about this.

Commited.