Support for addresses in Belgium.

I've added support for a closed list with the 10 Belgian provinces. I've learned in #939394: Support for UK addresses to try and keep things standardized. I've been looking for standard abbreviations for the provinces, but I as far as I know (and could find) these don't really exist.

CommentFileSizeAuthor
#13 1034002-revised.patch3.32 KBnetsensei
#9 1034002-revised.patch3.38 KBnetsensei
#8 1034002-revised.patch4.13 KBnetsensei
#6 1034002-without-provinces.patch3.36 KBnetsensei
#4 support_for_be_addresses-1034002.patch4.1 KBpol
addressfield-BE.patch4.73 KBnetsensei

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

There are standards :)

http://www.onzetaal.nl/advies/provincies.php

stroobl’s picture

stroobl commented

The patch seems to work, however I would add Brussels as a province, as it's not Flemish, nor Walloon Brabant ( http://nl.wikipedia.org/wiki/Provincies_van_Belgi%C3%AB ). Belgium is complicated. :)

I also believe a province field has no real added value for Belgium and should be optional. On my site, I would prefer to hide it.

WilliamV’s picture

WilliamV commented

Updates on this one?
Grtz.

pol’s picture

pol
the/that
Location Brussels
commented
StatusFileSize
new support_for_be_addresses-1034002.patch4.1 KB

Updated patch set.

This patch normalize the Province Name from standards (comment #1) and also add Brussels as a Province (Comment #2).

damien tournoud’s picture

damien tournoud commented

I also believe a province field has no real added value for Belgium and should be optional. On my site, I would prefer to hide it.

That raises a red flag for me. If in Belgium you traditionally don't expect to input the province / main administrative division, it should not be displayed on the form at all. I believe that most countries in the world do not expect to enter a main administrative division.

We have per-country forms precisely to allow such a thing.

netsensei’s picture

netsensei commented
StatusFileSize
new 1034002-without-provinces.patch3.36 KB

@Damien: That's true.

Since I live in Belgium, the province division is indeed not commonly used nor mandatory in Belgian (postal) correspondence. Moreover, provinces in Belgium are indeed a bit tricky. Especially when it comes to Brussels as Stroobl pointed out. ;-)

I intended the - optional - use of the province division something that could have been relevant on an international level. Intl. commerce applications do sometimes ask this information. Then again it is kind of weird as a Belgian to fill out the province field.

New patch attached: I eliminated the field entirely.

aspilicious’s picture

aspilicious commented 
+++ b/theme/addressfield-formatter--BE.tpl.phpundefined
@@ -0,0 +1,27 @@
+ * TODO: Describe what this template is here for.

Fill in the todo

+++ b/theme/addressfield-formatter--BE.tpl.phpundefined
@@ -0,0 +1,27 @@
\ No newline at end of file

Put a newline on the end of your files :)

Powered by Dreditor.

netsensei’s picture

netsensei commented
Status: Needs work » Needs review
StatusFileSize
new 1034002-revised.patch4.13 KB

Revised patch.

netsensei’s picture

netsensei commented
StatusFileSize
new 1034002-revised.patch3.38 KB

Okay. Last patch was a dud... new patch

Having said that: just noticed that I still need to strip the CVS tags and the description in the comments filled out for every existing template and include... but that sounds like a separate issue to me.

pol’s picture

pol
the/that
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

Patch #8 is ok for me.

pol’s picture

pol
the/that
Location Brussels
commented

Patch #9 is ok for me too.

There are no province handling in #9 but there are in #8.

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs work

No you should strip it out now, the Git migration should have stripped all the others if they are committed before the migration. We can't accept any patches with a cvs ID tag now :)

Srry :)

netsensei’s picture

netsensei commented
StatusFileSize
new 1034002-revised.patch3.32 KB

New attempt: now without the CVS tags... Hope this passes. :p

netsensei’s picture

netsensei commented
Status: Needs work » Needs review

Forgot to set the status... :-/

pol’s picture

pol
the/that
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

The patch is tested and ok for me.

stroobl’s picture

stroobl commented

The patch works, thanks.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Closed (won't fix)

The -reloaded branch has been merged. This doesn't appear to be needed anymore.