The menu type of admin/structure/trigger/unassign should be MENU_CALLBACK [#1037522]

Comment	File	Size	Author
#6	trigger_unassign-MENU_CALLBACK-1037552-6.patch	962 bytes	pillarsdotnet
#4	trigger_unassign-MENU_CALLBACK-1037552-4.patch	962 bytes	pillarsdotnet
#3	trigger_unassign-MENU_CALLBACK-1037552-3.patch	964 bytes	pillarsdotnet
#2	1037522.patch	446 bytes	montesq

Comment #1

montesq commented 23 January 2011 at 23:44

Version:

7.0

» 7.x-dev

Reproduced on 7.x-dev...

Log in or register to post comments

Comment #2

montesq commented 25 January 2011 at 19:03

Status:

Active

» Needs review

Status	File	Size
new	1037522.patch	446 bytes

The 'unassign' link shoud not be displayed.
I've tried to set the 'type' of this item menu to MENU_LOCAL_ACTION. The link has disappeared but is it the right type?

Log in or register to post comments

Comment #3

pillarsdotnet commented 15 July 2011 at 15:08

Version:	7.x-dev	» 8.x-dev
Issue tags:		+Needs backport to D7

Status	File	Size
new	trigger_unassign-MENU_CALLBACK-1037552-3.patch	964 bytes

~~I'm pretty sure that the correct type is MENU_CALLBACK~~

EDIT: bad patch. Use the next one instead.

Log in or register to post comments

Comment #4

pillarsdotnet commented 15 July 2011 at 15:08

Status	File	Size
new	trigger_unassign-MENU_CALLBACK-1037552-4.patch	962 bytes

I'm pretty sure that the correct type is MENU_CALLBACK

Log in or register to post comments

Comment #5

16 July 2011 at 03:39

Status:

Needs review

» Needs work

The last submitted patch, trigger_unassign-MENU_CALLBACK-1037552-4.patch, failed testing.

Log in or register to post comments

Comment #6

pillarsdotnet commented 16 July 2011 at 05:12

Status:

Needs work

» Needs review

Status	File	Size
new	trigger_unassign-MENU_CALLBACK-1037552-6.patch	962 bytes

Weird. Trying again.

Log in or register to post comments

Comment #7

pillarsdotnet commented 12 August 2011 at 22:30

Title:

Warning: Missing argument 3 for trigger_unassign() in trigger_unassign()

» The menu type of admin/structure/trigger/unassign should be MENU_CALLBACK

Log in or register to post comments

Comment #8

pillarsdotnet commented 12 August 2011 at 22:30

#6: trigger_unassign-MENU_CALLBACK-1037552-6.patch queued for re-testing.

Log in or register to post comments

Comment #9

xjm

she/her

English

commented 22 January 2012 at 20:17

Version:	8.x-dev	» 7.x-dev
Status:	Needs review	» Needs work
Issue tags:	-Needs backport to D7	+Needs tests

#764558: Remove Trigger module from core has been committed, so moving back to D7. We should additionally try to add an automated test for this if the bug is still reproducible. Thanks!