The commit log seems to replicate commits per branch or something.

  1. Create a project
  2. Make a commit
  3. git checkout -b 7.x-1.x
  4. git checkout -b 7.x-1.0-beta1
  5. git checkout -b 7.x-1.0-beta2
  6. git push --all

node/xxx/commits will now have 3 commits (identical) instead of just the one that it should have.

Comments

eliza411’s picture

Issue tags: +Known Issues

tagging until fixed.

marvil07’s picture

Project: Git on Drupal.org » Version Control API
Version: » 6.x-2.x-dev
Component: Miscellaneous » Views integration
Assigned: Unassigned » marvil07

Ok, I can confirm the bug, but it is not at the parsign level, so it should be a views integration problem, on the joins stuff.

marvil07’s picture

Title: Multiple duplicate commits show in commit log » Add a views field handler that retrieves all operation label names
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new5.92 KB

Hey I think this is ready!

This also modify the commitlog_global_commits default view to use it instead of the current versioncontrol label name views fields, that naturally end up in one row per vc_op_id per label.

sdboyer’s picture

Issue tags: +git phase 2

Doesn't seem to do the trick, at least not with my quick review on staging. Applied the patch, cleared caches and was still seeing one commit per branch.

marvil07’s picture

Status: Needs review » Needs work

Mmm.. I think the problem is that we need to change all views to use it. (maybe you are viewing one that I did not change, are you sure commitlog_global_commits is not working?)

I am now changing all the ones where there are repeated operations, but this is about vc_api, then we need to change vc_git ones and then vc_project ones :-/

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new10.25 KB

Ok, here the patch changing all the other vc_api views that were not changed.

If this is ok, I will follow with vc_git ones.

marvil07’s picture

marvil07’s picture

Status: Needs review » Fixed

Ok, after fixing a little notice I committed it!

Status: Fixed » Closed (fixed)
Issue tags: -Known Issues, -git phase 2

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4136a75 on repository-families, drush-vc-sync-unlock by marvil07:
    feature #1039042: Add a views field handler that retrieves all operation...

  • Commit 4136a75 on repository-families by marvil07:
    feature #1039042: Add a views field handler that retrieves all operation...