Make Model/SKU a unique target

Thanks Christoph. In a quieter moment, I'll take a look and see what can be integrated. It does make sense to make the SKU the unique target so that should be done I think.

Christoph, thanks for sharing. Hoping I can wrap my brain around what you have done. I'm still not sure why SKU needs its own processor when GUID and URL don't seem to.

Hi christoph,

Why does the module use Feed Nodes Processor instead of Node processor?

Maybe I'm missing something, but when I select Feeds Node processor I can't choose my product content type, I can only do that with Node processor.

There is no OlamaluFeedsProductProcessor to select.

Thanks Christoph.
string "'optional_unique' => TRUE," show marker in 7.x too, but no realy unique. I am looking for something which works in 7.x.

I'm going to close this for now. If a patch is supplied please reopen and I will apply it.

Pls have you seen or tried this - http://drupal.org/node/1307732#field_as_unique_id_7
[although for D7]

If you have not dealt with this problem I suggest you the following solution.

step 1.
uc_feeds.module - 16 line

    // Model
    $targets['uc_product:model'] = array(
      'name' => t('UC: Model/SKU'),
      'callback' => 'uc_feeds_feeds_set_target',
      'description' => t('Ubercart: !mapper', array('!mapper' => t('Model/SKU'))),
	  'optional_unique' => TRUE,
    );

step 1.
FeedsNodeProcessor.inc - 353 line

  protected function existingItemId(FeedsImportBatch $batch, FeedsSource $source) {

    // Iterate through all unique targets and test whether they do already
    // exist in the database.
    foreach ($this->uniqueTargets($batch) as $target => $value) {
      switch ($target) {
        case 'nid':
          $nid = db_result(db_query("SELECT nid FROM {node} WHERE nid = %d", $value));
          break;
        case 'url':
          $nid = db_result(db_query("SELECT nid FROM {feeds_node_item} WHERE feed_nid = %d AND id = '%s' AND url = '%s'", $source->feed_nid, $source->id, $value));
          break;
        case 'guid':
          $nid = db_result(db_query("SELECT nid FROM {feeds_node_item} WHERE feed_nid = %d AND id = '%s' AND guid = '%s'", $source->feed_nid, $source->id, $value));
          break;
        case 'uc_product:model':
          $nid = db_result(db_query("SELECT nid FROM {uc_products} WHERE model = '%s'", $value));
          break;
      }
      if ($nid) {
        // Return with the first nid found.
        return $nid;
      }
    }
    return 0;
  }

Here is a patch that solves the problem properly. It adds an UbercartFeedsNodeProcessor that allows to map to existing entities based on Model/SKU. This is a minimal processor based on FeedsNodeProcessor. To use it, just select it as processor, add a mapping on Model/SKU and set it as unique.

This is basically as described in #10, but without having to hack feeds module, which is a no go for a proper implementation.

I wrote a patch for this a month ago, but hadn't posted it. It's basically the same as @Frando's patch, but also does a few extra things. This is what it does:

• Provides a new "Ubercart Feeds Product Processor" class that extends FeedsNodeProcessor (like @Frando's patch).
• Moves all of the Ubercart product targets defined in uc_feeds_feeds_node_processor_targets_alter() into the new class (using the getMappingTargets() method). I would argue that this is the better way to do it, because you don't want to allow mapping product-specific fields to non-product node types. See the next item below for enforcing that... The only issue with doing this is that it will break existing importers that are using uc_feeds mappings, unless they are updated to use the new processor.
• Overrides the config form for the processor to ensure that only product node types can be selected.
• Fixes the "name" of pkg_qty and default_qty mapping targets. They were "UC: pkg_qty" and "UC: default_qty", respectively. Now they are "UC: Package Quantity" and "UC: Default Quantity".
• Overrides the buildNode() method and adds a "$node->uc_feeds_import = TRUE;" flag to nodes. This is just a handy flag that I'm using in hook_nodeapi() to act only on nodes that are being created/updated via this processor.

Maybe it makes sense to break this up into multiple patches, but I figured I would post it in full and open it up for discussion.

Minor whitespace fixes to previous patch.

Where is it that you place this patch for it to work?

I have placed UCFeedsProductProcessor.inc in modules/feeds/plugins and editied the uc_feeds.module however I am getting a error message on my site stating:Missing Feeds plugin UCFeedsProductProcessor. See __none__. Check whether all required libraries and modules are installed properly

Issue with this patch it allows you to set the SKU as unique but when importing all data related to UC is not stored.

@GregoryThomasFox: there is a great resource on how to apply patches on Drupal.org here: http://drupal.org/patch/apply -- please follow the instructions there, or ask for help in a more general location, so we can keep this issue focused on the issue.

Apply the patch using the standard patch application procedure, and be sure to clear your cache after you do so, because this patch adds a new processor class, which needs to be registered via CTools (will happen automatically with a cache clear). I suspect that doing both of those things will solve the issue you described in #15.

Can you elaborate on your comment in #16? It doesn't make sense to me.

@m.stenta I applied this patch manually and it has allowed me to set the SKU as a unique target in the feeds setting however when I upload a CSV file containing product information none of the Ubercart fields such as SKU and sale price get updated.

@GregoryThomasFox: you cannot *update* the SKU of a product if that is the field you're using as *unique*. If you try to do that, it will probably just create a new product for you with the new SKU.

What I mean is adding this patch allows me to set the Sku as unique however when importing the ubercart fields for a product dont get pulled through (even though they are mapped to do so) for instance the products title and image are pulled through as they are originally drupal fields but fields such as sell price and sku are not pulled through.

Like Masala, looking for a patch that works with D7 vers. of UC Feed Mappers

subscribe

Patch #13 working awesome.

Now we need to port it to D7.

Created patch for D7.

This seems to be working for me. I realize that there's better ways of writing drupal queries now but this does seem to do the trick. Feel free to refactor.

I tried patch #25 and could not get it to work.

When I was debugging I found that the model array looks correct at the end of the processor_targets_alter call however using devels dd function I could not get any thing from the uc_feeds_sku_mapper_unique function. I think the function is not being called at all. Anyone have any ideas as to why that would be?

[model] => Array
(
  [name] => UC: Model/SKU
  [callback] => uc_feeds_set_target
  [description] => Ubercart:Model/SKU
  [optional_unique] => 1
  [unique_callbacks] => Array
  (
    [0] => uc_feeds_sku_mapper_unique
  )
)

Nevermind I got it to work properly. I had an out of date module.