With References now split off into its own contrib space, it's probably no longer the responsibility of the devel_generate.module to provide integration. This patch provides include files for both node_reference and user_reference.

CommentFileSizeAuthor
#13 reference-generate-1045018-12.patch2.05 KBkarens
#12 reference-generate-1045018-12.patch0 byteskarens
#9 references-devel_generate_1.patch2.04 KBrickvug
#6 references-devel_generate.patch2.04 KBsteven jones
references-devel_generate.patch2.22 KBles lim

Comments

les lim’s picture

les lim
he/they
Primary language English
commented

Companion issue to remove References integration from Devel: #1045020: Remove obsolete nodereference and userreference module integration

Status: Needs review » Needs work

The last submitted patch, references-devel_generate.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review

references-devel_generate.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, references-devel_generate.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Postponed

Makes sense. However, we fix bugs before touching new features, so settings to postponed.

steven jones’s picture

steven jones commented
StatusFileSize
new references-devel_generate.patch2.04 KB

Remove the prefixes from the patch file.

moshe weitzman’s picture

moshe weitzman commented

I'd like to remove this code from devel. Please consider committing this patch or similar code so devel can proceed. I could commit now but then users would have no easy option for genering this data. Thanks.

yched’s picture

yched commented
Status: Postponed » Active

I commented in #1045020-7: Remove obsolete nodereference and userreference module integration

rickvug’s picture

rickvug commented
StatusFileSize
new references-devel_generate_1.patch2.04 KB

The patch at #6 applied cleanly but was broken due to the function rename at #1154998: Promote _node_reference_potential_references() to the "official" API. Attached is an updated patch with the rename taken into account. Works well for me when generating nodes.

Liaz’s picture

Liaz commented
Status: Active » Reviewed & tested by the community

Yes ! rickvug's patch works !!
thxxxxxxxx
Liaz

karens’s picture

karens commented
Status: Reviewed & tested by the community » Needs work

I have had success with nodes but some of my colleagues were trying user references and said they did *not* work. I'll poke around and see if I can tell anything. It looks like _user_reference_potential_references() is failing somehow.

karens’s picture

karens commented
Status: Needs work » Needs review
StatusFileSize
new reference-generate-1045018-12.patch0 bytes

Found the problem. There is no such function as _user_reference_potential_references(). It is user_reference_potential_references(), not a private function. New patch attached.

karens’s picture

karens commented
StatusFileSize
new reference-generate-1045018-12.patch2.05 KB

The new files did not get added to that patch, leaving it empty, another attempt.

karens’s picture

karens commented
Status: Needs review » Fixed

I went ahead and committed this, since it has been tested and I know it is working.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hctom’s picture

hctom
Primary language German
commented

Are there any plans for a release date for this? ;-)