While working on some translation features I went through translation.pages.inc and (1) added a lot of comments and (2) moved a few lines to give more sense.

The result is attached in a very simple patch.

CommentFileSizeAuthor
#8 commenting_and_cleanup_in_translation_pages_inc-1045392-8.patch4.46 KBitangalo
translation-page-clarified-6.patch4.07 KBitangalo

Comments

Status: Needs review » Needs work

The last submitted patch, translation-page-clarified-6.patch, failed testing.

itangalo’s picture

itangalo commented
Status: Needs work » Needs review

Robot, please retest!

itangalo’s picture

itangalo commented

translation-page-clarified-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, translation-page-clarified-6.patch, failed testing.

itangalo’s picture

itangalo commented

I'm at a loss for why this patch fails. The actual code hasn't changed, just been slightly moved around, and the patch applies without problems on my local machine.

I'm trying putting it in the test queue again.

itangalo’s picture

itangalo commented
Status: Needs work » Needs review

translation-page-clarified-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, translation-page-clarified-6.patch, failed testing.

itangalo’s picture

itangalo commented
Status: Needs work » Needs review
StatusFileSize
new commenting_and_cleanup_in_translation_pages_inc-1045392-8.patch4.46 KB

New patch, created using the new standards with Git branching and everything.
Robot, please retest!

Status: Needs review » Needs work

The last submitted patch, commenting_and_cleanup_in_translation_pages_inc-1045392-8.patch, failed testing.

itangalo’s picture

itangalo commented

[insert bad words here]

I'll let this rest for a while. Maybe some other day I can make a patch that's really going to be accepted. This is silly.

tr’s picture

tr commented
Status: Needs work » Closed (duplicate)

Closed as duplicate of #1045396: Code cleanup in translation.pages.inc. If these changes get put into D8 in that other issue, they can be backported to D7 and D6, also in that other issue. No need to have two threads discussing the same changes.