Closed (fixed)
Project:
Examples for Developers
Version:
7.x-1.x-dev
Component:
Block Example
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Jan 2011 at 19:47 UTC
Updated:
12 May 2011 at 17:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
rfayI'm all in favor *if* and *when* #1045606: hook_block_info doc should use visibility constants goes in. I've subscribed. @droplet if you can provide a patch when that one gets committed it would be great.
I do hate that this would result in a fatal with any earlier version of D7 after we commit it.
Comment #2
rfayI didn't realize these were already defined, so I'm fine with this. Patch awaited.
Comment #3
droplet commentedComment #5
rfayThanks for the patch. You have to make the patch relative to root of the project directory (in the examples directory). That's why it failed to apply.
Comment #6
droplet commentedthanks.
let me try, almost forgot how to create a CVS patch.
Comment #7
rfayComment #8
dave reidComment #9
tr commentedFixed. Commit 556a3d06ac14c15bf31b5dac3399ec859de99c60
Technically, using BLOCK_VISIBILITY_LISTED adds a dependency to the Block module. Which is needed anyway if we're going to do anything with blocks, so I also added that to the dependencies in the block_example.info file.
Comment #10
rfayThis needs to go into 8.x too, doesn't it?
If you're not already using git cherry-pick, you'll probably want to.
Thanks for the awesome work on these.
Comment #11
tr commentedI actually did cherry pick the commit and fixed this in 8.x-1.x, I just forgot to post the D8 commit number here. (Posting commit # is a new procedure for me, I'm going to forget once in a while.)
8.x-1.x commit 17880d5a3053d81c469ca25c1a3a1fc5d8c1e000