Currently, argument summaries for reference fields display raw nids (resp. uids)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

Assigned: Unassigned » yched

Working on it.

yched’s picture

Status: Active » Needs review
FileSize
5.93 KB

Attached patch adds the two missing D6 behaviors - display node title (resp user name) instead currently of nid (resp uid) :
- in arguments summary lists (relies on the 'name table' and 'name field' properties used by the default views_handler_argument handler)
- in title '%n' placeholders (relies on a custom references_handler_argument handler)

But, after much head-scratching, I only manage to have the 'arguments summary' part work by patching views to fix a possible bug there. I'll post the patch in the Views queue and ask for feedback over there.

Also, the references_handler_argument handler introduced here is common to both noderef and userref, and thus needs to be exposed at a higher level (in D6, such handlers were exposed by content.module).
Therefore, the patch introduces references.module as a wrapper for common functionnality. Other views handlers or plugins will need this too.

No commitment on the actual rate to which bits of 'similar' code from noderef and userref will be refactored and factorized out into references.module in the future, but at least the door is open.

yched’s picture

yched’s picture

fix whitespace styling error

yched’s picture

Status: Needs review » Fixed

#1059646: Argument summaries : 'title table' not correctly joined ? got fixed in Views dev, so the patch now works fine (retested).
Committed (1st d.o git commit, at last !).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.