Request for a new permission to view all userpoints transaction, but not to admin them.

I'll give it a try!
Up to the moment, I am good enough in php, and have been reading the Drupal code a lot, but have not yet tried making patches

Ok there.
I am modifying the following things:
- definition in the beginning define('USERPOINTS_PERM_VIEW_TRANS', 'view all userpoints transactions');
- hook_perm - adding USERPOINTS_PERM_VIEW_TRANS

Now about important things. The system with view list permission is a bit buggy.
The module currently uses the userpoints_access_my_points function via the menu access system to determine, whether to give access to /myuserpoints/*. Hence all permission checks should be made in that function.
However, that function cannot currently perform the needed checks since it does not know, which user we are requesting userpoints for - ourself or other user.

Therefore I am adding
'access arguments'=>array(1) in the hook_menu definition of myuserpoints

Then I am completely rewriting userpoints_access_my_points
putting all the logic there.

And I am removing all permission checks from userpoints_list_my_userpoints()

Now you won't result in getting the link "view details" but resulting in 403 when you follow this link

Hope this helps!

I am patching against 1.2

The code of userpoints_access_my_points follows here.

function userpoints_access_my_points() {
	global $user;  

 if ($user->uid === 1 || user_access(USERPOINTS_PERM_ADMIN)) {
    return TRUE;
  } // root, admin perms

   if (user_access(USERPOINTS_PERM_VIEW_TRANS)) {
    return TRUE;
  } // view all transaction perms

  // User which are displaying points for
  $uid = (int)arg(1);
  if ($uid) {
    if ($uid != $user->uid) {
      // If not the same as logged in user
      return FALSE;
    }
  }

  return (user_access(USERPOINTS_PERM_VIEW) || user_access(USERPOINTS_PERM_VIEW_OWN));
  // viewing transactions of myself


}

The comments in that issue (http://drupal.org/node/1048706) reminded me...

What's currently incorrect is that the permission to view details differs from the situation when "view details" is printed in user profile.
If everybody has the permission to view, but not the permission to admin, then that link is always there, but most users result it 403 when following it...

Ok, I think I'll switch to dev then and provide a patch based on it...

A new patch for the latest dev.
The changes are minimal now!
Looks like I've repeated a part of the dev changes in my previous patch to the release version

Thanks for guiding me :) I am slowly learning GIT, in fact I've already applied for moving my own module out of the sandbox, but for the moment I still do not know GIT well enough.

Is there any manual about writing tests for modules?

Ok there, I changed the permission check (that was trivial of course) and learned how to make a patch with the use of git.
The patch I am uploading now has been made with the use of git.

P.S. Since the code is being modified, the changes of my patch are becoming more and more simple, but that's actually a good place to learn all those thing about patches, git and workflow!

Attempt 2