Provide a settings form for general media settings including media dialog theme and file extensions

Should a variable be getting a variable? I guess so, because there are cases where the admin theme will not work w/ Media due to the tight spacing constraints. I suppose this is okay, but can I get a +1 from someone else?

I was wondering something similar as Jacob. In theory this patch makes sense, but not all sites will even be using an admin theme, in which case I think this will wind up using their default theme instead. I'm trying to imagine (for example) what a theme like Garland would look like inside the media dialog. It's probably worth taking a look to see what kind of disaster it is :)

Granted, many themes (including Garland) look pretty bad inside the Overlay also, and this is a similar situation. However, in those cases you might just choose not to use the Overlay module. Choosing not to use the media browser seems like a bigger sacrifice to me.

I have the same hesitation as @David_Rothstein. I don't think that in the vast majority of cases it should be a problem to hard-code it with Seven as the default, because AFAIK, it should be okay to use that theme even if it isn't enabled (can someone test that to make sure)? Thus, the only case I can think of where it might be a problem would be if someone has entirely removed the Seven theme from their file system. In which case they can also override the variable...

I think a better solution than setting the variable to a variable would be to add a configuration option to alter the setting from the UI.

+1 to a dropdown to select the theme in media settings.

I'm renaming this because this patch does more than was specified.

I started with the original goal, but then we've got other bugs about not being able to change the allowed extensions without settings.php tomfoolery, and the form looked quite barren with only one field.

The descriptions are... wordy. But it's hard to explain wtf this stuff is. Please feel free to edit them and re-post patches.

R to the TBC

Committed.

"It can be different from your site's theme because the many site themes do not work well in the small windows which media uses.

not sure what this means - maybe "the" isn't supposed to be there?

Fixed

Here's an update which defaults to the admin theme when not specified.

slight update to the submit hand;er.

Committed it w/o review.