DrupalDefaultEntityController::resetCache() supports and $ids argument, but entity_load() never passes this in. This means that contrib modules implementing other methods of caching other than static aren't able to selectively clear caches when the argument is passed, see #1050562: Does not support $reset argument.

Patch just passes the argument on if it's given.

CommentFileSizeAuthor
#5 drupal-entity_load_reset-1050568-5.patch716 bytestekante
#4 drupal-entity_load_reset-1054616-4.patch716 bytestekante
entity_load_reset.patch725 bytescatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Trivial fix.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Closed (duplicate)

This overlaps #1049124: node_load() with $reset = TRUE needs some tweaking, where there are discussions whether this should be done or not.

tekante’s picture

tekante commented
Issue summary: View changes
StatusFileSize
new drupal-entity_load_reset-1054616-4.patch716 bytes

Adding a reroll of the patch solely because drush make leaves .rej and common.inc.~1~ files when attempting to use the current version. Does so as make falls through the git apply lines and the -p1 attempt of patch leaves these files around (the subsequent -p0 attempt of patch succeeds at patching so there is actually nothing wrong with the original patch). There seems to be no workable set of flags for patch to make it not leave at least the common.inc.~1~ flag around (though "-r - " prevents the .rej file) so attaching a patch that should allow the git apply to succeed (suspect it is failing as it needs too large a fuzz factor).

Should it ever be needed, this was with Drush 5.9, git 1.8.3.4, patch 2.6 on Ubuntu 10.04 LTS

tekante’s picture

tekante commented
StatusFileSize
new drupal-entity_load_reset-1050568-5.patch716 bytes

Correcting patch name as I used the node from the patch naming guide instead of the one for this issue :(

tekante’s picture

tekante commented