We've got a pretty regular, normalized schema which means we can be using inner joins instead of Views' default (left) for, as far as I can think, everything. This patch instructs all of our implicit joins to be made with inner.

I'm posting it rather than just directly committing it so I can get a sanity check - I'm not missing anything with this, am I? The vc_git views have to be left joins, but the rest of these tables should be in lock-step.

CommentFileSizeAuthor
vcapi-views-inner-joins.patch2.87 KBsdboyer

Comments

marvil07’s picture

marvil07 commented
Status: Active » Needs review

I have just duplicted an older issue about the same #1044776: Please use INNER JOINs where possible just because this issue have code.

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed

OK, can't see any outstanding problems, so I committed this.

Status: Fixed » Closed (fixed)
Issue tags: -Perfomance, -git phase 2, -git sprint 10

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Perfomance, +git phase 2, +git sprint 10

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 0b037e5 on repository-families, drush-vc-sync-unlock by sdboyer: 
    Issue #1050594: Use inner joins in Views wherever possible.

  • Commit 0b037e5 on repository-families by sdboyer: 
    Issue #1050594: Use inner joins in Views wherever possible.