Storm Team module schema

Yes, I'd be happy with this, as long as the node still refers to a team rather than team member. if I understand correctly, in the dv, each row would now be a member hence multiple rows for a team.

I don't have the code in front of me right now, but did think it was done using nids in the serialised array. Full name values are really only cached there so that lists of team members can be created without doing full node loads on those.

Ok, I need to look at this in more detail with a screen bigger than an inch wide, but a few initial comments:

- Deprecated views handler can be removed
- Update function should start the 62xx series as this will go into the 6.x-2.x branch
- I was a bit confused about the update function. Is it really looking at the names?
- There are a couple of helper functions in the update function. If they are only called once, would it be clearer to keep all of the logic in the update function itself?

Its great to use a multi select for the members - how much work would it be to do this in a separate patch (an issue already exists) so these can be tested independently?

Are there downsides to not storing the name? For example when displaying in views?

This patch has only minor changes from #10. Will commit if it passes the testbot check still.

Committed to 2.x.

Hi,

i ran update.php and all teams are gone (on 3 different systems).

Which Storm team tables are in the database, and do they contain the new or old structure?

Did update.php report any errors?

After the update the stormteam table has the new structure

Here the update messages

The following queries were executed
stormteam module
Update #6200

* CREATE TABLE {stormteam_6200} ( `vid` INT NOT NULL DEFAULT 0, `nid` INT NOT NULL DEFAULT 0, `mnid` INT NOT NULL DEFAULT 0, PRIMARY KEY (vid, nid, mnid) ) /*!40100 DEFAULT CHARACTER SET utf8 */ ENGINE=InnoDB
* DROP TABLE {stormteam}
* ALTER TABLE {stormteam_6200} RENAME TO {stormteam}

But afterwards there are only 17 rows in the table and no team is displayed in the teams list. We have over 100 Teams, but no one is left after the update

I 'll have a look at the code at the weekend ...

Were these installations off the shelf storm, or did they have patches applied?

3 problems:

• 1. nid and vid have to be changed in stormteam_update_6200(), because else the stormteam vis is used as stormteam nid after the update
• 2. the second sql result overwrites the first of selecting all teams in stormteam_update_6200(). that is why all the teams are gone after the update
• 3. in stormteam_list each team has to be selected only once. Because of the new structure each team nis is now multiple times in the table, not only once. A normal distinct in the query solves this problem

Here is the patch ...

Needs review, for testbot.

Committed to 2.x, thanks.

Here another Patch, which fixes 3 forgotten positions which used old team schema.
These positions are:
storm.module - storm_get_assignment_options
stormteam.module - stormteam_access_sql, stormteam_storm_rewrite_where_sql
and a forgotten a in organization in stormteam_user_return_teams

+++ stormteam/stormteam.module	21 Feb 2011 21:33:17 -0000
@@ -222,15 +222,16 @@ function stormteam_storm_rewrite_where_s
-      $cond = " WHEN 'stormteam' THEN (SELECT IF($cond,1,0) FROM {stormteam} ste1 WHERE ste1.vid=${primary_table}.vid) ";
+      $cond = " WHEN 'stormteam' THEN (SELECT DISTINCT 1 FROM {stormteam} ste1 WHERE ste1.vid=${primary_table}.vid AND ($cond)) ";

What is the reasoning behind this bit of the patch?

Powered by Dreditor.

For this line i needed about 1 hour to figure out, how to change this for the new table schema.
With the old SQL you get an MySQL error that the subselect returns more than one value ("Subquery returns more than 1 row query"), because ste1.vid=vid does not return one value anymore. So the condition moved to the where, to only select the specific entry. The DISTINCT is needed for the condition 'Storm team: view own' (uid=$uid), in this case you get every time all users from that team. If you are not in the team and do not created that team, it returns nothing and you do not select this team.
Works for me so far.
Error happens on db_query(db_rewrite_sql("SELECT n.nid, n.title FROM {node} n LEFT JOIN {stormteam} s ON n.vid = s.vid WHERE n.status = 1 AND n.type="stormteam" ORDER BY title"));

OK, makes sense. Will commit later.

something is still wrong with the function stormteam_access_sql (in stormteam.module).
On http://..../storm/teams it works, but on http://.../storm/tickets i got a mysql error

User warning: Unknown column 'ste.mnid' in 'where clause' query: SELECT n.nid FROM node n WHERE (n.language ='de' OR n.language ='' OR n.language IS NULL) AND ( (n.uid=82 OR ste.mnid = 1990) AND ('storm_access'='storm_access') AND ( n.type = 'stormteam' ) )ORDER BY n.title ASC in _db_query() (line 164 of /[...]/includes/database.mysqli.inc).

It have something todo with the filter, because i can't select any team. A look at the SQL statement, points out there is no join stormteam statement.

Error in my last Patch.
Here the last Patch with the fix.
I removed the join stormteam in storm.module, but is needed for the rewrite. sry for that...

OK, assuming the testbot agrees, I will commit #25.

Committed #25 to 2.x.