On the Storm Content Type 'Teams' when revision is activated editing a Team makes it disappear

Steps to reproduce issue
1. Go to /admin/content/node-type/stormteam
Expand 'Workflow settings'. Check 'Create new revision' box

2. Go to /storm/teams Click on the + button to add a new Team
Under 'Team Member 1:' add anybody
Under 'Team Name:' Type in anything
Click on 'Save' button
On the next screen the new Team will be display somewhere in the list

3. Click on the 'Edit' icon next to the newly created Team
Under 'Team Member 2:' add anybody
Click on 'Save' button
On the next screen the Team you just edited has disappear
Expected result is the Team you just edited should not disappear

If you redo above same steps but at step one you uncheck 'Create new revision' box there are no issue. So it seems that revision is related to this issue.

Similar issue was fixed for Storm invoices module at http://drupal.org/node/857154

Reproduced with
* Drupal 6.19 fresh install
* Storm 6.x-1.35

CommentFileSizeAuthor
#9 patch-works.png28.1 KBfrancewhoa
#3 storm--1052180-3.patch725 bytesjuliangb

Comments

juliangb’s picture

Version: 6.x-1.35 » 6.x-2.x-dev

Sounds like a nid / vid mixup. Needs to be fixed first in 2.x and backported.

francewhoa’s picture

Thanks juliangb. I would be happy to provide testing.

juliangb’s picture

Status: Active » Needs review
StatusFileSize
new725 bytes

Does this patch help at all?

juliangb’s picture

Version: 6.x-2.x-dev » 6.x-1.x-dev

Committed to 2.x. Retest on 1.x.

juliangb’s picture

#3: storm--1052180-3.patch queued for re-testing.

juliangb’s picture

Status: Needs review » Fixed

Committed to 1.x.

francewhoa’s picture

Thanks juliangb for the quick reply. Storm is really well maintain :)

I'll try testing patch today. Then post result here.

I know patch is already committed but we need to test anyway before applying to our installations.

francewhoa’s picture

Confirming patch in #3 works

Tested with
* Drupal 6.19 fresh install
* Storm 6.x-1.x-dev fresh install

francewhoa’s picture

StatusFileSize
new28.1 KB

Francewhoa note to self: Patch works. Attaching screenshot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.