Fix metadata-assertions for referenced entities.

If the referenced entity is of a known bundle type, drupal commerce should add a 'bundle' => 'foo' key to the property info of the entity reference. If the bundle is not known beforehand though, it's unavoidable that you'll have to check it yourself.

However, indeed "metadata assertions" won't work currently for nested data selections ala entity:reference. -> Changing the issue title.
For now, a possible work-a-round is to pass the referenced entity to another rule component and do the check there.

Marked #1065496: Data selectors only don't include fields of child entities as duplicate.

Subscribing.

Subscribe +1

Subscribe

Subscribing

Subscribing

Subscribing

Sub +!

subscribing

Subscribing!

+1

Subscribing

I hate to do this, but... subscribing.

+1
having the same problem right now ^^

Subscribing. Same issue. In addition, I'm trying to add a rule where I check and order status and payment type. Each has a way of referencing each other through an ID number... but even if I load the entity by fetching by ID or value, it only returns a partial object that can't be updated.

Different issue, so ignore. But I feel it's somewhat related.

subscribe

Subscribing

subscribing

subscribe

subscribe

subscribe

Subscribing

subscribing

subscribing

subscribing..

just wondering, Is this issue expected to be solved in the near future?

I'm aware of the issue and I'm going to take a look at it as time permits. If you need it earlier you are welcome to chime in or organizing someone else doing it for you.

adding tag

An workaround is to use rules actions with php evaluation. Don't forget to enable the core module PHP filter.
Here is a sample code, for the use case Adding a Taxonomy Term To Drive Discounts, see http://www.drupalcommerce.org/node/461

The rule is: event Calculating the sell price of a product, Conditions Order is a shopping cart,Parameter: Order: [line-item:order], Actions Multiply the unit price by some amount,Parameter: line-item:line-item-id
At amount , click switch to data selection

This code works only with Conditions Order is a shopping cart,Parameter: Order: [line-item:order], because before adding to cart line item object doesn't exists.
In php evaluation input the following code:

$van_line_item_id['0'] = $value; #$value from rules with data selector line-item:line-item-id
	$van_line_item_ent=entity_load('commerce_line_item',$van_line_item_id);
	
	$van_product_id[0]=$van_line_item_ent[$value]->commerce_product['und'][0]['product_id'];
	$van_product_ent=entity_load('commerce_product', $van_product_id);
		
	$van_product_price=$van_product_ent[$van_product_id[0]]->commerce_price['und'][0]['amount'];
	
	
	 $van_tags = $van_product_ent[$van_product_id[0]]->field_tag_subdomenii['und'];   
     foreach ($van_tags as $van_tag  ) { 
     	$van_tag_objects[] =  taxonomy_term_load($van_tag['tid']);
     }
     #....
     #Return whatever values depending on the taxonomy found...

subscribing

subscribe

Thanks for the work around @EuroDomenii. I unfortunately need to do this for a client ASAP, so I'm glad to have something. The question is, shouldn't this be considered hackish or do you think this will be the only way? considered standard/best practice?

Php evaluation is a smart feature of fago, I suppose just for this kind of situations

On the other hand, drupal commerce developers totally rely on rules for dynamic price modification ( in commerce_product_pricing.module, function commerce_product_calculate_sell_price there is no hook, only
rules_invoke_event('commerce_product_calculate_sell_price', $line_item); ). Even this looks hackish, it is clean.

The nice alternative is http://www.drupalcommerce.org/node/461, but is for a particular use case.
With php evalution is more general... You just take the data selectors that rules gives you in the context, and with entity_load you can grab whatever you want from drupal.

ok, I finally managed to work on this and created a working patch. I really regret using metadata-wrappers for tracking configuration-time metadata as that just makes issues like this complicated - a simple, fat $info array would be probably much simpler to handle. Well, that's something we could refactor anytime or towards d8..

Attached patch works for me, e.g. this rule works now (given all content-types, fields and latest og are there):

{ "rules_og_rules_test" : {
    "LABEL" : "og rules test",
    "PLUGIN" : "reaction rule",
    "REQUIRES" : [ "rules", "og" ],
    "ON" : [ "og_membership_insert", "og_membership_update" ],
    "IF" : [
      { "entity_is_of_type" : { "entity" : [ "og-membership:entity" ], "type" : "node" } },
      { "entity_has_field" : { "entity" : [ "og-membership:entity" ], "field" : "field_tags" } }
    ],
    "DO" : [
      { "drupal_message" : { "message" : [ "og-membership:entity:title" ] } },
      { "LOOP" : {
          "USING" : { "list" : [ "og-membership:entity:field-tags" ] },
          "ITEM" : { "tag" : "Current tag" },
          "DO" : [ { "drupal_message" : { "message" : [ "tag:name" ] } } ]
        }
      }
    ]
  }
}

To ensure this does not break, we need to cover it with tests. Let's add
* a rule using a generic entity property and asserting its entity type
* a rule asserting a field of a referenced entity
* a rule asserting the bundle, and so the fields of the referenced entity + ensure the property can be passed on as argument for parameters requiring the asserted bundle.

Patch attached. Please test.

As tests have shown, the patch had problems with assertions directly on variables and asserting bundles. Fixed that.

implemented tests + committed it.

Woohoo! Thanks for all the great work on this!

NICE!

subscribe!

is this fix in dev now?

EDIT: My bad, its in release :D

I am creating a Rule for commerce so when an order is completed, the customer name is populated in a product custom field.

For what I understand, Orders Entity has a reference to Line Items Entity,
and Line Items has a reference to commerce products.

So I try to use " Entity has field" twice like this

"Commerce order" has field "Line Items"
"Commerce order" has field "Commerce product"
(I can't set "Line items" has field "Commerce product" as I would expect)

But I can not see the Products and their fields into scope.

so I want to ask, Is it possible to navigate trough referenced entities?? thanks

Sorry pitxels, this issue isn't the right place to post your question. I'd recommend trying either on www.drupalcommerce.org or the Drupal Commerce issue queue.

The key thing I've struggled with is properly defining the conditions to then manipulate it in the actions section. Try reading this writeup by Ryan: http://www.drupalcommerce.org/faq/rules-field-data-selection

What is missing is a list of the unique fields each entity type has to you can properly scope it.