Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I saw this software implementing wikipedia's List of common misspellings and wondered what would happen if I ran it against drupal core.
Comment | File | Size | Author |
---|---|---|---|
#16 | 1054848-run-codespell.py-on-drupal-7-branch.patch | 156.6 KB | barraponto |
#9 | 1054848-drupal-codespell-9.patch | 157.22 KB | barraponto |
#5 | 1054848-drupal-codespell-5.patch | 154.65 KB | barraponto |
#5 | review.txt | 4.18 KB | barraponto |
drupal-typing-errors.patch | 164.36 KB | barraponto | |
Comments
Comment #1
barraponto CreditAttribution: barraponto commentedThe patch itself needs review, while I'll take it as a task reviewing the typo-related issues and seeing if this patch makes sense.
btw, the patch is big (160kb) because there was a typo in the 60k of aaaaaaa lines (in comments, of course).
Comment #2
andypostSounds useful
Comment #3
Lars Toomre CreditAttribution: Lars Toomre commentedGood to see quite a few core spelling mistakes caught by this script... Rather than creating one massive core patch that is overwhelming to review, perhaps this patch file could be broken up into chunks of say 25 spelling mistakes? It would be easier to review and get committed I suspect.
Ideally this functionality in time could be added to the coder module. Great find!!
Comment #4
Damien Tournoud CreditAttribution: Damien Tournoud commented(... and others like this one)
This only affect comments and some UI strings, so it should be safe otherwise.
Comment #5
barraponto CreditAttribution: barraponto commentedFixed the error Damien Tournoud pointed out, ran a newer version of codespell.py against latest drupal.
I'm attaching a review file to make it easier to see what has been fixed.
Comment #6
Lars Toomre CreditAttribution: Lars Toomre commentedAll of those spelling changes in review.txt look good, including the doens't highlighted by Damien Tournoud. I did not check each in turn in the patch file, but presume that changes are like before.
Comment #7
Damien Tournoud CreditAttribution: Damien Tournoud commentedLooks all good. Thanks for the patch!
Comment #8
klausidoes not apply anymore
Comment #9
barraponto CreditAttribution: barraponto commentedOnce again.
Comment #11
Mac_Weber CreditAttribution: Mac_Weber commentedI reviewed 1054848-drupal-codespell-9.patch looks good.
Why not getting rid of that aaaaaaaaaa.... comment, too?
The comment is: "A large comment block to test for segfaults and speed. This is 60K a's. Extreme but useful to demonstrate flaws in comment striping regexp. aaaa..."
Located at line 7 of
./modules/simpletest/files/css_test_files/comment_hacks.css.unoptimized.css
We really need that?
Comment #12
Mac_Weber CreditAttribution: Mac_Weber commented#9: 1054848-drupal-codespell-9.patch queued for re-testing.
Comment #13
Mac_Weber CreditAttribution: Mac_Weber commentedComment #14
chx CreditAttribution: chx commentedAnyone running screaming due to the size of the patch: 120K is from the 60k A used for the css tests *twice* because it's context for a line of change. Joys of patch.
Comment #15
Dries CreditAttribution: Dries commentedReviewed all the changes and committed the patch to 8.x.
The patch doesn't apply to 7.x so I couldn't backport it. Probably easiest to run codespell.py on 7.x.
Thanks!
Comment #16
barraponto CreditAttribution: barraponto commentedRan codespell.py on the 7.x branch.
Comment #17
klausiComment #18
Mac_Weber CreditAttribution: Mac_Weber commentedComment #19
webchickOk, since the RTBC queue is looking pretty good around now, seems like it makes sense to commit this now. SO...
Committed and pushed to 7.x. Thanks! Yay, better spelling. ;)