Token support doesn't work yet

Subscribing

Here is the file that handles location tokens. Just drop this in the location module and it rename it to location.tokens.inc (remove the .txt extension). Clear your cache and it should work. To fully clean up the old code, you should delete the location.token.inc file and remove the calls made to it in the location.module.

can You provide a patch in git format?

Hopefully I did that right.

When I added this file, I got tokens that looked like this: [node:location:city:?] and consequently, that didn't work......

I wonder if this is a problem with old code lingering around. What files do I need to delete old code from? It was unclear for me, when I read the above.

This is the new dynamic way for tokens to work. Try using [node:location:city] which is the same as [node:location:city:0] to get the city.

OK, i'll try it again. I just thought the question mark that was showing up was indicative of a problem...

When using either [node:location:city:0] or [node:location:city] I recieve the notice:

Notice: Undefined property: stdClass::$location in location_tokens() (line 103 of /var/www/drupal/drupal-7.8/sites/default/modules/location/location.tokens.inc).

The token then does not resolve and leaves me with the token text rather than the token value. I am attempting to use the tokens with Automatic Nodetitles.

Any thoughts? Thanks!

Subscribing

subscribing.

I think this should fix the issue in #11.

Thanks so much for this. I see the option for [account:location], are we able to do [account:location:city] to get the separate fields?

I just tried using [account:location] and only the raw token shows up.

You'd definitely need to use [account:location:city] or [account:location:name] in order to use location tokens.

[account:location] won't be replaced. You need to go further down.

Thanks j_ten_man. What would be the full list of those tokens. Is it this?

[account:location:name]
[account:location:street]
[account:location:additional]
[account:location:city]
[account:location:province]
[account:location:postal_code]
[account:location:country]

@animelion - all of those you listed plus:
[account:location:province_name]
[account:location:latitude]
[account:location:longitude]
[account:location:country_name]

I've put the code in the file sites/all/modules/location/location.token.inc and deleted the old location/token.inc file.
Then I commented out in sites/all/modules/location/location.module:
/**
* Implements hook_token_values().

function location_token_values($type, $object = NULL) {
require_once(DRUPAL_ROOT . '/' . drupal_get_path('module', 'location') . '/location.token.inc');
return _location_token_values($type, $object);
}
*/
/**
* Implements hook_token_list().

function location_token_list($type = 'all') {
require_once(DRUPAL_ROOT . '/' . drupal_get_path('module', 'location') . '/location.token.inc');
return _location_token_list($type);
}
*/
I cleared the cache but I still don't see location: options under URL aliases/patterns replacement patterns -> nodes
I have cck fields locations fields that I want to use in the URL.
What am I doing wrong?
Thanks so much

Does this patch only work for Node Location fields? I am using Location CCK and I cannot get this patch to work.
Locations tokens do not show.
There are no error messages.

For others who are having trouble with this patch.
Node Locations works.
Location CCK does not work.

Thanks for letting us know. Is there anyway to do it with Location CCK?

Just as an FYI... Not sure if this is relative to this or not but I don't see tokens for individual fields (phone, address, state, etc) in Views after applying this patch.

I managed to modify location_cck.module, this is the first step, this is not fine

Anyone get user location tokens to work correctly?? I'm trying to get them to show up in Panels title (manually set or from pane) and even though I can see "%user:location" in the substitutions menu. It does not show up. I tired drilling down farther into %user:location:city and %user:location:city:0, but those do not show up either.

@rubenlor, the attachment in #25 is in a wrong format. It is probably a modified location_cck.module, not a diff patch (like the patch in #14), isn't it?
Can you please provide a patch in the diff patch format ?

+1 for anyone who can help with a proper patch

OK, here is the patch based on the #25 and the latest location_cck.module 7.x-3.x-dev.
This still needs work and cleaning the code.

Applied the patch in #29 but I don't think it's workings, or at lease these tokens no longer work.

[account:location:street], [account:location:city], [account:location:province] [account:location:postal_code]

REMOVING, unrelated

REMOVING, unrelated

I am a bit confused. The attached location.tokens.inc_.txt to #4 fixed my problem. However, this thread is diverging from node location to cck location.

#4 appears to fix the NODE location. As for the rest...

None of the patches patched anything for me. But the patch threw no errors, only silence.

My fault. Please ignore.
Totally unrelated.

hello there!
any news for location cck and 7.x-3.x-dev?

#7 - Patch - Brilliant - Thankyou!!!

from #36

Patches in #25/#29 for location_cck seem to be just the token code copied from location. The function names aren't correct and have a hard-coded field name.

Any updates on token support for cck location 7.x-3.x?
Thank you for your hard work.

problems with patch 29:

• implements location_token_info() and location_tokens() in location_cck module. these functions should be in location.token.inc, and location_cck_token_info() and location_cck_tokens() should be in location_cck.module.
• hard-codes "node", "field_location", "und" and "0", instead of offering token support for arbitrary entities, fields, languages, and deltas
• only includes a subset of a location instance's columns -- street, city, province name, post code, country name -- instead of all a location's columns
• comments out old hook implementations, rather than removing them
• spacing

+1 subscribing for Location CCK tokens support. Any news? Is there a working patch or dev release? Thanks

The patch provided in #14 seems to work for Location node.

Would it be possible to commit this ?

Hi Jibus,

Can Anyone help me? I tried all the patches but still not working.

Patch #14 works for me (Used it to add location related data in url alias)

Thx!

Any chance that token support for Location CCK will be in dev version soon ?

Any news on this ?

bot?

the patch needs reroll

The patch provided in #14 works for the general location module.

The patch #25 & #29 are for the submodule CCK location module and needs some love.

Should we create an other issue regarding tokens in CCK location module ?

#14: token-support-1056154-14.patch queued for re-testing.

to #55
We can handle #25 and ##29 here after #14 commited or if You want to give love for those patches by youself You can create follow-up issues to this )

#14 commited pushed to 7.x-3.x-dev

#25 and #29 still need some love

Thanks!
tagged as Needs test for #14

http://drupal.org/node/1942736 tagged in alpha release

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -514,27 +515,36 @@ function theme_location_cck_field_popup($variables) {
+    if ($type == 'field' || type == 'all') {
+    ¶

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -514,27 +515,36 @@ function theme_location_cck_field_popup($variables) {
     unset($fields['locpick']);
+    ¶
+    ¶

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -514,27 +515,36 @@ function theme_location_cck_field_popup($variables) {
-    return $tokens;
+   ¶

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -514,27 +515,36 @@ function theme_location_cck_field_popup($variables) {
+  ¶
     $tokens = array();
+  if ($type == 'field' || $type == 'all') ¶
+      {
     $item = $object[0];

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -563,11 +573,125 @@ function location_cck_token_values($type, $object = NULL) {
+    ¶
   }

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -563,11 +573,125 @@ function location_cck_token_values($type, $object = NULL) {
+}
+ * ¶

+++ b/sites/all/modules/contrib/location/contrib/location_cck/location_cck.moduleundefined
@@ -563,11 +573,125 @@ function location_cck_token_values($type, $object = NULL) {
+    'description' => t('Tokens related to location.'),
+  ¶

a lot of trailing whitespace errors for #29 http://drupal.org/coding-standards#indenting despite the fact that patch do not applies against latest dev

anyway this is a feature request )

woops

#14: token-support-1056154-14.patch queued for re-testing.

Latest one needs work

Attached is a patch that I have working for this feature request. I removed the hook_token_list() and hook_token_value() functions and replaced them with hook_token_info() and hook_tokens() functions.

The patch creates a new token for each location field in the database. So if you have more than one location field created, a new token will be generated for each field.

Please, Upload patch in git diff format http://drupal.org/patch
Not in txt

Sorry about that. I renamed the file and re-attached.

#70 commited pushed to 7.x-3.x
Patch has a lot of whitespace errors!!!

Just a minor question about the last committed patch:
It gives me warnings when importing feeds with location_cck fields... More specifically, I tracked the problem down to this point in code:

function location_cck_tokens (hook_tokens implementation)
......
    // Loop through the tokens.
    foreach ($tokens as $name => $original) {
      // Break our token into an array to use later.
      $fields = explode(':', $name);
      $entity = $fields[0];
      $field = $fields[1];

According to the API, the $tokens is structured as [machinename] => [type:token]...
However, this code above assumes that $name (i.e. the key of the $tokens array) has the colon character ":" for exploding...
This gives an error because obviously $fields[1] has an undefined index...

Can you please take a look ?
I assume that explode function must be applied to the $original instead of the $name

Thanks for your efforts.

#72 looks like a follow-up bug
Please fill it...

The follow-up already exists: #2119967: [Needs steps to reproduce] Notice: Undefined offset: 1 in location_cck_tokens() (line 622 of location_cck.module).