As noticed in #1046784: Strings in simpletest_requirements() are not using $t(), in hook_requirements() of system.api.php, one of the calls uses t() instead of $t().
It's not strictly a problem since it is protected in if ($phase == 'runtime') (and, of course, the code is just for demonstration). But I think it should be fixed to set a good example. The code in the surrounding lines all uses $t().
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1056416-use-proper-translation-function.patch | 645 bytes | devin carlson |
| #1 | 1046784-follow-up-system-api-php.patch | 637 bytes | bfroehle |
Comments
Comment #1
bfroehle commentedSimple patch.
Comment #2
devin carlson commentedLooks good, as you mentioned all of the surrounding code also uses $t().
As patches should now be made against D8, I've attached a patch which makes the same change but against D8.
Comment #3
bfroehle commentedTagging for backport to D7. The patch is documentation only.
Comment #4
dries commentedCommitted to 7.x and 8.x. Good catch.