Taxonomy resource. Port to D7

+++ resources/taxonomy_resource.inc
@@ -277,6 +279,12 @@ function _taxonomy_term_resource_create($term) {
+  if (!isset($term->vid)) {

This is the only part I have a question about. Is it really necessary? Drupal generally doesn't protect users from errors like this, and I kind of feel like if someone passes in a malformed term then that is their problem.

The rest of the patch looks good though

Powered by Dreditor.

Taxonomy resource is a mess. Here is a new patch that combines yuriy's changes with a rewritten permissions concept that is much more sane. As far as the piece I questioned above, I was talking in IRC about how we need a coherent way to deal with updates where the identifier in the body doesn't match the identifier in the path. Patch for that forthcoming.

New patch with less typos

Patch looks good,

My one an only concern are things like this,
+ $vocabulary = (object) $vocabulary;

WE are typecasting through the entirety of Services and I believe its caused issue in the pass about struct vs array.

What are we doing about this? Should we define a standard for handling this, like, Everything we deal with should be an object, and converted to an array if necessary? Or everything should be an array and converted to an object if necessary?

It just seems to keep coming up and maybe this should be in another Task, but I just want to know what your thoughts are.

Edit: RE #3. I think its absolutely imperative that we try and mae the development experience of Services as easy to use as possible. Without it adoption will be extremely slow unless we have like the best documentation ever done on a drupal project. If we can do that great, but it might be easier to catch things like that in the long run.

Hello ygerasimov, I'm a newbie with drupal, php and opensource software. I don't know if this is the metod to report bugs, so sorry if not is this.

I found a bug using taxonomy get terms, for example, trying http://myserver/my endpoint-rest/term/2 produce Fatal error: Call to undefined function taxonomy_get_term() in C:\wamp\www\sites\all\modules\services\resources\taxonomy_resource.inc on line 247

When Reading the taxonomy_resource.inc on line 247, there is a call to the function taxonomy_get_term() that not is in the 7.x version.

Thank you very much for your work!

ygerasimov, great and quick! :-D . Aplying the #2 patch, this http://myserver/my-endopoint-rest/vocabulary/2 and this http://myserver/my-endopoint-rest/term/2 ARE OK!.

This http://myserver/my-endopoint-rest/node are OK but http://myserver/my-endopoint-rest/vocabulary and this http://myserver/my-endopoint-rest/term don't return results. It's must to return the collections of vocabulary and terms?. I'm not sure if this is a bug, because the index clausule in taxonomy vocabulary resource and the index clausule in taxonomy term resource not exist.

Thank you again!

Tests and patches look great, however the public function dsm($var) { probably needs to be moved elsewhere.

Do that and Ill commit

Nice job, this is RTBC for me.

Ok, I created two alias, one to vocabulary and another for terms, this is the reason form my urls...

I needed the index in term and vocabulary to expose to a client aplication the diferent values, for example of a term inside a vocabulary.

I thought that this was a functionality similar than "Get comments: GET /services/rest/node/123/comments"

I Understand that this must be a diferent issue.

Thank you very much!

This needs a reroll after recent commits. I made the changes but I am having trouble with the patch. Will get it up tomorrow, but I think it looks good. One thing I would like to see not just here but elsewhere is tests that assure users without access fail (in addition to that users with access succeed.)

I finally committed this! Thank you ygerasimov for all the work.

Yayy

Yayy