both "email" and "e-mail" in the same sentence. Patch changes "email" -> "e-mail"

CommentFileSizeAuthor
#8 1057270-email_ui_typo.patch844 bytesfranz
#3 drupa.interfacetypo.patch836 bytesfranz
drupa.interfacetypo.patch844 bytesfranz

Comments

franz’s picture

franz
any
Location Montréal
commented
Status: Active » Needs review

ops...

Status: Needs review » Needs work

The last submitted patch, drupa.interfacetypo.patch, failed testing.

franz’s picture

franz
any
Location Montréal
commented
Status: Needs work » Needs review
StatusFileSize
new drupa.interfacetypo.patch836 bytes

Oops, wrong patch command...

franz’s picture

franz
any
Location Montréal
commented
Issue tags: +Novice

Adding tag

franz’s picture

franz
any
Location Montréal
commented
Version: 7.x-dev » 8.x-dev

I think this needs to go on 8.x as well.

franz’s picture

franz
any
Location Montréal
commented
Issue tags: -Novice

#3: drupa.interfacetypo.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, drupa.interfacetypo.patch, failed testing.

franz’s picture

franz
any
Location Montréal
commented
Title: Typo on interface text » Typo on interface text - 'emai' spelling
Status: Needs work » Needs review
StatusFileSize
new 1057270-email_ui_typo.patch844 bytes

Re-rolling

franz’s picture

franz
any
Location Montréal
commented
Title: Typo on interface text - 'emai' spelling » Typo on interface text - 'email' spelling
James_Stallings’s picture

James_Stallings commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D6, +Needs backport to D7

Looks good, D8/7/6 please.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: -Needs backport to D6, -Needs backport to D7

Heh. What a silly bug. I confirmed in http://drupal.org/style-guide/content that we use "e-mail" even though this isn't quite standardized in some other places from a quick grep.

I don't personally think this is worth breaking strings for in a stable release, though. I checked with Gábor and he agreed for D6.

So removing the tags and marking back to just 8.x. But it's good to go.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Comitted to 8.x. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.