Ctools page_manager supports the ability for modules to expose a methodology for overriding paths that module may provide. In this case, page_manager's ability to already handle media entities out of the box would be complimented if the default media/%media path were overrideable. This is pretty easy to do, and wouldn't add any dependencies, we'd simply get the benefit of the plugin if page_manager is installed.

Patch coming.

CommentFileSizeAuthor
#8 1058098_1.patch5.85 KBeclipsegc
#1 1058098.patch5.78 KBeclipsegc

Comments

eclipsegc’s picture

eclipsegc commented
StatusFileSize
new 1058098.patch5.78 KB
eclipsegc’s picture

eclipsegc commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1058098.patch, failed testing.

eclipsegc’s picture

eclipsegc commented

Uhh... why doesn't that apply?

aaron’s picture

aaron commented
Status: Needs work » Needs review

#1: 1058098.patch queued for re-testing.

aaron’s picture

aaron commented

for consistency and ease of uninstallation:

+ if (variable_get('media_media_view_disabled', TRUE)) {

and

+ variable_set('media_media_view_disabled', TRUE);

might consider using media's namespaced variable functions:

media_variable_get('media_view_disabled'); and media_variable_set('media_view_disabled', TRUE); and setting the default to TRUE.

Status: Needs review » Needs work

The last submitted patch, 1058098.patch, failed testing.

eclipsegc’s picture

eclipsegc commented
Status: Needs work » Needs review
StatusFileSize
new 1058098_1.patch5.85 KB

ok, I think this should fix the patch.

eclipsegc’s picture

eclipsegc commented

Maintaining this as a branch in my own sandbox for media module right now, you can address it here, it will make merging much easier whenever you get around to it:

git clone --branch 1058098 http://git.drupal.org/sandbox/eclipsegc/1081502.git

JacobSingh’s picture

JacobSingh commented

Is this still relevant IIRC, you got commit access and added this.

eclipsegc’s picture

eclipsegc commented

I didn't actually add it yet, but I will... so yes it's relevant, but I'm not sure I need anyone to review it at this point.

jeffwidman’s picture

jeffwidman commented

sub

Shadlington’s picture

Shadlington commented

Was this committed yet?

eclipsegc’s picture

eclipsegc commented

It was not, I was told a big change to media is in the pipes and that I might as well hold off.

FrequenceBanane’s picture

FrequenceBanane commented

so, what's up now ?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

This is definitely 2.x territory now.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Add ctools page_manager support for media/%media path » Add ctools page_manager support for file/%file path
Project: D7 Media » File Entity (fieldable files)
Status: Needs review » Needs work

This also needs to be moved to the file_entity as it's responsible for the file/%file paths.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Closed (duplicate)

Marking this as a duplicate of #1564456: Provide support for Page manager, Panels, and Panelizer which has much more updated work, even though I should have just continued with this issue, sorry. I'll make sure EclipesGc gets commit credit mention.

eclipsegc’s picture

eclipsegc commented

Oh thanks lol. I appreciate :-D