Documentation suggest that the hook is invoked after the user tables are removed, but a look at the api code for user_delete_multiple, it shows the module_invokes occurring before the delete methods are called.

CommentFileSizeAuthor
#4 1058762-2.patch712 bytesmontesq
#2 1058762.patch716 bytesmontesq

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Documentation problem with hook_user_delete » hook_user_delete doc has wrong order of operations

Agreed, the doc is wrong on hook_user_delete. Thanks for reporting!

montesq’s picture

montesq commented
Status: Active » Needs review
StatusFileSize
new 1058762.patch716 bytes

Proposed patch as attachment.
Advice are welcome...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

The new text is fine, thanks! The only thing that should be fixed is the line wrapping. We try to wrap docblocks at as close to the 80th column as possible, so field_attach_delete() should be moved up to the previous line (by my editor's calculation, that brings the line to exactly 80 characters).

montesq’s picture

montesq commented
StatusFileSize
new 1058762-2.patch712 bytes

Yes indeed.
This should be fixed on this new version of the patch.
Thank you.

montesq’s picture

montesq commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1058762-2.patch, failed testing.

montesq’s picture

montesq commented
Status: Needs work » Needs review

#4: 1058762-2.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks for taking care of this!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.