Autocomplete bug when tagging a node with terms containing commas [#1060282]

When tagging a node with tags containing commas, autocomplete removes double-quotes around previously entered tags.

How to simulate problem:
1) Create terms "term, 1" and "term, 2" so that autocomplete can offer them.
2) Try to tag a node with both terms using autocomplete
2.1) When the textfield contains "term, 1" and you append , ter the autocomplete offers term, 2 and others
2.2) Click the offered term, 2
3) The first tag looses double-quotes, splitting into 2 tags term and 1

Expected behavior:
Autocomplete appends "term, 2" and leaves previous tags untouched (in double-quotes).

Current behavior:
Autocomplete appends "term, 2" but changes the original content of the textfield so that double-quotes get lost.

Comment	File	Size	Author
#12	tagging.patch	679 bytes	BayerMeister
#10	tagging2.patch	846 bytes	BayerMeister
#9	tagging2.patch	881 bytes	BayerMeister
#7	tagging2.patch	889 bytes	BayerMeister
#5	tagging.patch	820 bytes	BayerMeister
#4	tagging.patch	838 bytes	BayerMeister
#2	taxonomy.pages_.inc_.patch	873 bytes	BayerMeister

Comments

Comment #1

BayerMeister commented 13 February 2011 at 14:21

I think it is here:
taxonomy.pages.inc:124:

    $prefix = count($array) ? implode(', ', $array) .', ' : '';

This line concatenates the previous terms, but does not enclose them in double quotes even if needed (array of terms contains terms with commas or double-quotes inside).

I'll try to make a patch and append it here. I'll be glad to get directions on how to get this into the next update and how to make sure it gets fixed in D7 (which I don't use yet) as well.

Comment #2

BayerMeister commented 13 February 2011 at 14:40

Status:

Active

» Needs review

Status	File	Size
new	taxonomy.pages_.inc_.patch	873 bytes

Here is a patch. No magic there, just surrounding terms with double-quotes and doubling double-quotes in them.

I tested it and it works. Should have no side effect.

Now I'd appreciate some guidance. What now?

Comment #3

13 February 2011 at 14:51

Status:

Needs review

» Needs work

The last submitted patch, taxonomy.pages_.inc_.patch, failed testing.

Comment #4

BayerMeister commented 14 February 2011 at 11:43

Status:

Needs work

» Needs review

Status	File	Size
new	tagging.patch	838 bytes

Ups. I'm sorry :-/ My first patch and I did it backwards. Here this one should be OK.

Comment #5

BayerMeister commented 14 February 2011 at 11:59

Status	File	Size
new	tagging.patch	820 bytes

...and with UNIX line endings...

Comment #6

14 February 2011 at 12:11

Status:

Needs review

» Needs work

The last submitted patch, tagging.patch, failed testing.

Comment #7

BayerMeister commented 14 February 2011 at 12:18

Version:	6.20	» 6.x-dev
Status:	Needs work	» Needs review

Status	File	Size
new	tagging2.patch	889 bytes

Last attempt. I downloaded the latest sources, followed steps in http://drupal.org/patch/create, used GNU diff.
It is a hard thing to contribute simple things it seems :-)
If it doesn't pass now, I'll let someone else apply it. I think the .patch file is OK.