Multiple token trees on same page can both get expanded when clicking one [#1062492]

Comment	File	Size	Author
#8	1062492-treetable-keep-events-in-same-table.patch	670 bytes	dave reid
#7	1062492-treetable-keep-events-in-same-table.patch	730 bytes	dave reid
#6	1062492-treetable-keep-events-in-same-table.patch	705 bytes	dave reid
#1	allow_multiple_tables.patch	2.3 KB	berdir

Comment #1

berdir

German

Switzerland

commented 15 February 2011 at 22:49

Status:

Active

» Needs review

Status	File	Size
new	allow_multiple_tables.patch	2.3 KB

Here is a patch that fixes it in token.module by adding a prefix to the used id's.

The prefix is only added if there is more than a single table, this could easily be changed add one by default.

Patch is quite simple I think :)

Log in or register to post comments

Comment #2

fago

German

Vienna

commented 22 February 2011 at 16:04

hm, why not use classes instead of ids if its not unique? Or, drupal_html_id() ?

Log in or register to post comments

Comment #3

berdir

German

Switzerland

commented 22 February 2011 at 16:08

Could also use drupal_html_id(), the problem is that it is a mix of an id and classes. First, we add an id, which needs to be unique and then we have a number of classes (all rows that have the previous with the id as the parent) which need to reference to that id.

But yeah, it might be possible to use drupal_html_id() once then then re-used what has been returned.

Log in or register to post comments

Comment #4

dave reid

he/him

English

Nebraska USA

commented 22 February 2011 at 21:42

Issue filed upstream with the library at http://plugins.jquery.com/content/cannot-have-multiple-tree-tables-same-...

Log in or register to post comments

Comment #5

moonray commented 6 June 2011 at 10:40

Subscribe.

Log in or register to post comments

Comment #6

dave reid

he/him

English

Nebraska USA

commented 26 July 2011 at 02:42

Status	File	Size
new	1062492-treetable-keep-events-in-same-table.patch	705 bytes

Using drupal_html_id will not allow us to cache the token tree's output. And modifying the library to use classes rather than IDs is a bigger step then it looks. Please try the following patch which changes the behavior of the childrenOf and parentOf functions to search only the 'current' treeTable.