In Drupal 7, we can replace some custom code with a built-in PHP5 function. :)

@see http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/drupal...

CommentFileSizeAuthor
#4 mollom.hmac-php5.4.patch991 bytessun
mollom-HEAD.hmac-php5.0.patch1.13 KBsun

Comments

dries’s picture

dries commented

Sweet! If the tests pass, this is RTBC. :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

mollom-HEAD.hmac-php5.0.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.hmac-php5.4.patch991 bytes

Re-rolled against git master.

dries’s picture

dries commented

Committed to 7.x-rest.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Also committed it to the 'master' branch -- is that 7.x proper?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

master == HEAD/7.x-1.x-dev currently. Still waiting for official git rules or statements regarding "master" vs. "7.x-1.x" branches.

7.x-rest is the REST API feature branch. I'll keep that in sync.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

There is already community consensus to not use master - use named branches.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

What happens with the existing master branch though? Delete it? Or can it be renamed?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Just leave it? Or remove all the files from it and leave your README.txt saying to use a named branch.

dries’s picture

dries commented

If it can be renamed, I'd simply rename it. Not sure if it can though.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit c8c5656 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #1062704 by sun: using PHP5 HMAC.

  • Commit c8c5656 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #1062704 by sun: using PHP5 HMAC.