theme_versioncontrol_diffstat() currently calls theme() recursively as many times as elements are included in the diffstat (5,7 or 9). This is nice abstraction in theory but it appears to be causing lots of extra theme calls, and is indicating a potentially huge number of calls when profiling with certain URLs (which will be very prominent after launch).

This attached patch simply removes the extra theme calls, the theme function can still be overridden but it would need to be overridden as a whole.

CommentFileSizeAuthor
versioncontrol_diffstat_extra_theme_calls.patch2.4 KBmikey_p

Comments

halstead’s picture

halstead commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Tested fine.

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » mikey_p

Agreed with the RTBC. This is a clear win. Patch is good. Commit at will. ;)

mikey_p’s picture

mikey_p commented
Assigned: mikey_p » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed.

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » mikey_p

cross-poster. ;)

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 10

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 10

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 0c1dd72 on repository-families, drush-vc-sync-unlock by mikey_p: 
    #1065340 by mikey_p: Performance improvement - remove extra calls to...

  • Commit 0c1dd72 on repository-families by mikey_p: 
    #1065340 by mikey_p: Performance improvement - remove extra calls to...