Kept getting the warning with beta3.

Strict warning: Only variables should be passed by reference in fontyourface_preprocess_page() (line 511 of /opt/development/emckenna/opic/sites/all/modules/contrib/fontyourface/fontyourface.module).

line in question is here:

if (file_prepare_directory(dirname($destination), FILE_CREATE_DIRECTORY)) { 
...

Patch will first assigns a variable the output of dirname() and uses the variable in the function.

see http://the-stickman.com/web-development/php/php-505-fatal-error-only-var... for more info on the warning.

CommentFileSizeAuthor
#1 fontyourface-1065928.patch710 bytesemackn

Comments

emackn’s picture

emackn commented
Status: Active » Needs review
StatusFileSize
new fontyourface-1065928.patch710 bytes

Here's the patch.

Status: Needs review » Needs work

The last submitted patch, fontyourface-1065928.patch, failed testing.

sreynen’s picture

sreynen commented
Status: Needs work » Fixed

Thanks. Must be a bug in the test bot; the patch doesn't actually cause a fatal error. This is committed to dev. The Font Squirrel provider module had the same problem, so I fixed it there too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.